improve error message for calling a method on a raw pointer with an unknown pointee #111954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
compiler-errors
approved these changes
May 25, 2023
| @@ -18,7 +18,7 @@ hir_typeck_struct_expr_non_exhaustive = | |||
| cannot create non-exhaustive {$what} using struct expression | |||
|
|
|||
| hir_typeck_method_call_on_unknown_type = | |||
There was a problem hiding this comment.
I wonder if we should also rename this slug.. method_call_on_unknown_raw_pointee?
|
r=me with nit or not, if you do fix it then please squash into one commit instead of adding it on top @bors delegate+ |
asquared31415
force-pushed
the
unknown_ptr_type_error
branch
from
d270737 to
fbf2a7d
Compare
|
@bors r=compiler-errors |
|
📌 Commit fbf2a7d9e2958a1fe786a9b3241d6c5e5a08bf0e has been approved by It is now in the queue for this repository. |
bors
added
S-waiting-on-bors
|
@bors r- testing a thing |
bors
added
S-waiting-on-author
|
@bors r+ |
|
📌 Commit fbf2a7d9e2958a1fe786a9b3241d6c5e5a08bf0e has been approved by It is now in the queue for this repository. |
bors
added
S-waiting-on-bors
|
lol you mean @bors r=compiler-errors |
|
💡 This pull request was already approved, no need to approve it again.
|
|
📌 Commit fbf2a7d9e2958a1fe786a9b3241d6c5e5a08bf0e has been approved by It is now in the queue for this repository. |
|
oh yeah rollup too @bors rollup |
|
☔ The latest upstream changes (presumably #111858) made this pull request unmergeable. Please resolve the merge conflicts. |
bors
added
S-waiting-on-author
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 26, 2023
…iaskrgr Rollup of 5 pull requests Successful merges: - rust-lang#111384 (Fix linking Mac Catalyst by including LC_BUILD_VERSION in object files) - rust-lang#111899 (CGU cleanups) - rust-lang#111940 (Clarify safety concern of `io::Read::read` is only relevant in unsafe code) - rust-lang#111947 (Add test for RPIT defined with different hidden types with different substs) - rust-lang#111951 (Correct comment on privately uninhabited pattern.) Failed merges: - rust-lang#111954 (improve error message for calling a method on a raw pointer with an unknown pointee) r? `@ghost` `@rustbot` modify labels: rollup
…nknown pointee, and add some tests
asquared31415
force-pushed
the
unknown_ptr_type_error
branch
from
fbf2a7d to
b19466a
Compare
|
@bors r=compiler-errors |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 26, 2023
…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#111714 (Stop confusing specification levels when computing expectations.) - rust-lang#111927 (Migrate `item_static` to Askama) - rust-lang#111954 (improve error message for calling a method on a raw pointer with an unknown pointee) - rust-lang#111973 (Update current implementation comments for `select_nth_unstable`) - rust-lang#111976 (Generate docs for bootstrap itself) - rust-lang#111977 (Make errors from `x doc` less verbose) - rust-lang#111987 (do not prefer substs relate during coherence) - rust-lang#111991 (Change ty and const error's pretty printing to be in braces) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old error message had very confusing wording.
Also added some more test cases besides the single edition test.
r? @compiler-errors