Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 6 pull requests #111993

Closed
wants to merge 14 commits into from
Closed

Commits on May 25, 2023

  1. Configuration menu
    Copy the full SHA
    462a96c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    844c1cc View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    f2bdaf1 View commit details
    Browse the repository at this point in the history

Commits on May 26, 2023

  1. Generate docs for bootstrap itself

    This verifies the intra-doc links are correct, and hopefully makes
    things easier for new contributors.
    jyn514 committed May 26, 2023
    Configuration menu
    Copy the full SHA
    b084c52 View commit details
    Browse the repository at this point in the history
  2. fix for Self not respecting tuple Ctor privacy

    This fixes rust-lang#111220 by checking the privacy of tuple constructors using `Self`, so the following code now errors
    
    ```rust
    mod my {
        pub struct Foo(&'static str);
    }
    
    impl AsRef<str> for my::Foo {
        fn as_ref(&self) -> &str {
            let Self(s) = self; // previously compiled, now errors correctly
            s
        }
    }
    ```
    fee1-dead committed May 26, 2023
    Configuration menu
    Copy the full SHA
    be44860 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    6827a41 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    e7fa993 View commit details
    Browse the repository at this point in the history
  5. remove unnecessary .ok() calls

    lcnr committed May 26, 2023
    Configuration menu
    Copy the full SHA
    b6b9611 View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#103291 - ink-feather-org:typeid_no_struct_m…

    …atch, r=dtolnay
    
    Remove structural match from `TypeId`
    
    As per rust-lang#99189 (comment).
    
    > Removing the structural equality might make sense, but is a breaking change that'd require a libs-api FCP.
    
    rust-lang#99189 (comment)
    
    > Landing this PR now (well, mainly the "remove structural equality" part) would unblock `const fn` `TypeId::of`, since we only postponed that because we were guaranteeing too much.
    
    See also rust-lang#99189, rust-lang#101698
    Dylan-DPC authored May 26, 2023
    Configuration menu
    Copy the full SHA
    c05413a View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#111245 - fee1-dead-contrib:temp-fix-tuple-s…

    …truct-field, r=lcnr
    
    fix for `Self` not respecting tuple Ctor privacy
    
    This PR fixes rust-lang#111220 by checking the privacy of tuple constructors using `Self`, so the following code now errors
    ```rust
    mod my {
        pub struct Foo(&'static str);
    }
    
    impl AsRef<str> for my::Foo {
        fn as_ref(&self) -> &str {
            let Self(s) = self; // previously compiled, now errors correctly
            s
        }
    }
    ```
    Dylan-DPC authored May 26, 2023
    Configuration menu
    Copy the full SHA
    2780050 View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#111928 - c410-f3r:dqewdas, r=eholk

    [RFC-2011] Expand more expressions
    
    cc rust-lang#44838
    
    Expands `if`, `let`, `match` and also makes `generic_assert_internals` an allowed feature when using `assert!`. `#![feature(generic_assert)]` is still needed to activate everything.
    
    ```rust
    #![feature(generic_assert)]
    
    fn fun(a: Option<i32>, b: Option<i32>, c: Option<i32>) {
      assert!(
        if a.is_some() { 1 } else { 2 } == 3
          && if let Some(elem) = b { elem == 4 } else { false }
          && match c { Some(_) => true, None => false }
      );
    }
    
    fn main() {
      fun(Some(1), None, Some(2));
    }
    
    // Assertion failed: assert!(
    //   if a.is_some() { 1 } else { 2 } == 3
    //     && if let Some(elem) = b { elem == 4 } else { false }
    //     && match c { Some(_) => true, None => false }
    // );
    //
    // With captures:
    //   a = Some(1)
    //   b = None
    //   c = Some(2)
    ```
    Dylan-DPC authored May 26, 2023
    Configuration menu
    Copy the full SHA
    9990164 View commit details
    Browse the repository at this point in the history
  9. Rollup merge of rust-lang#111952 - cjgillot:drop-replace, r=WaffleLapkin

    Remove DesugaringKind::Replace.
    
    A simple boolean flag is enough.
    Dylan-DPC authored May 26, 2023
    Configuration menu
    Copy the full SHA
    915c659 View commit details
    Browse the repository at this point in the history
  10. Rollup merge of rust-lang#111976 - jyn514:doc-bootstrap, r=ozkanonur

    Generate docs for bootstrap itself
    
    This verifies the intra-doc links are correct, and hopefully makes things easier for new contributors.
    
    Note that this will conflict with rust-lang#111955, i'm pretty sure i typo-ed some of the intra-doc links lol
    Dylan-DPC authored May 26, 2023
    Configuration menu
    Copy the full SHA
    101dc0c View commit details
    Browse the repository at this point in the history
  11. Rollup merge of rust-lang#111987 - lcnr:alias-relate-coherence, r=Box…

    …yUwU
    
    do not prefer substs relate during coherence
    
    r? `@compiler-errors`
    Dylan-DPC authored May 26, 2023
    Configuration menu
    Copy the full SHA
    c98ff21 View commit details
    Browse the repository at this point in the history