Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x.py print more detailed format files and untracked files count #114347

Merged
merged 2 commits into from
Aug 2, 2023

Conversation

chenyukang
Copy link
Member

Fixes #114245

@rustbot
Copy link
Collaborator

rustbot commented Aug 1, 2023

r? @albertlarsan68

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Aug 1, 2023
@chenyukang chenyukang force-pushed the yukang-fix-114245-fmt-count branch from 45710d0 to e80fc99 Compare August 1, 2023 22:40
@chenyukang chenyukang force-pushed the yukang-fix-114245-fmt-count branch from e80fc99 to 58bda47 Compare August 1, 2023 22:42
Copy link
Member

@albertlarsan68 albertlarsan68 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@albertlarsan68
Copy link
Member

Thanks for the PR!
@bors r+

@bors
Copy link
Contributor

bors commented Aug 2, 2023

📌 Commit 58bda47 has been approved by albertlarsan68

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 2, 2023
Noratrieb added a commit to Noratrieb/rust that referenced this pull request Aug 2, 2023
…ount, r=albertlarsan68

x.py print more detailed format files and untracked files count

Fixes rust-lang#114245
Noratrieb added a commit to Noratrieb/rust that referenced this pull request Aug 2, 2023
…ount, r=albertlarsan68

x.py print more detailed format files and untracked files count

Fixes rust-lang#114245
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 2, 2023
Rollup of 5 pull requests

Successful merges:

 - rust-lang#114079 (Use `upvar_tys` in more places, make it return a list)
 - rust-lang#114166 (Add regression test for resolving `--extern libc=test.rlib`)
 - rust-lang#114321 (get auto traits for parallel rustc)
 - rust-lang#114335 (fix and extend ptr_comparison test)
 - rust-lang#114347 (x.py print more detailed format files and untracked files count)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit da2b237 into rust-lang:master Aug 2, 2023
@rustbot rustbot added this to the 1.73.0 milestone Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

x.py fmt counts untracked files as formatted?
4 participants