Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core/slice: Fix inconsistency between docs for rotate_left and rotate_right #116221

Merged
merged 1 commit into from
Sep 28, 2023

Conversation

ArchUsr64
Copy link
Contributor

@ArchUsr64 ArchUsr64 commented Sep 28, 2023

A minor fix for documentation inconsistency as shown below:

Before:

2023_09_28_0k3_Kleki

After:

image
Docs url: https://doc.rust-lang.org/stable/core/primitive.slice.html#method.rotate_left

@rustbot
Copy link
Collaborator

rustbot commented Sep 28, 2023

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @cuviper (or someone else) soon.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Sep 28, 2023
@ChrisDenton
Copy link
Member

Consistency is nice, thanks!

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Sep 28, 2023

📌 Commit 5e26e8c has been approved by ChrisDenton

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 28, 2023
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 28, 2023
…iaskrgr

Rollup of 3 pull requests

Successful merges:

 - rust-lang#116191 (Add regression test for rust-lang#56098)
 - rust-lang#116214 (rustdoc: rename `issue-\d+.rs` tests to have meaningful names)
 - rust-lang#116221 (core/slice: Fix inconsistency between docs for `rotate_left` and `rotate_right`)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit ff958ae into rust-lang:master Sep 28, 2023
11 checks passed
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Sep 28, 2023
Rollup merge of rust-lang#116221 - ArchUsr64:patch-1, r=ChrisDenton

core/slice: Fix inconsistency between docs for `rotate_left` and `rotate_right`

A minor fix for documentation inconsistency as shown below:
## Before:
![2023_09_28_0k3_Kleki](https://github.com/rust-lang/rust/assets/83179501/569a49d3-0d72-49ac-92a2-ef5e1d94130b)
## After:
![image](https://github.com/rust-lang/rust/assets/83179501/afd0c8d7-6fb7-4878-801b-b47c8fe23c7d)
Docs url: https://doc.rust-lang.org/stable/core/primitive.slice.html#method.rotate_left
@rustbot rustbot added this to the 1.74.0 milestone Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants