Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rollup of 3 pull requests #116230

Merged
merged 8 commits into from
Sep 28, 2023
Merged

Rollup of 3 pull requests #116230

merged 8 commits into from
Sep 28, 2023

Conversation

matthiaskrgr
Copy link
Member

Successful merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

apekros and others added 8 commits September 27, 2023 18:05
@apekros
Add regression test for rust-lang#56098
ac9707d
@notriddle
Add crate_name to test so that it can be renamed
79195d5
@notriddle
Rename issue-\d+.rs tests to have meaningful names
7cd8b2c
@notriddle
rustdoc: add URLs for test issues
0487237
@ArchUsr64
changed 'rotate' to 'rotating'
5e26e8c
@matthiaskrgr
Rollup merge of rust-lang#116191 - apekros:issue-56098, r=petrochenkov
ba0d977 
Add regression test for rust-lang#56098

Closes rust-lang#56098
@matthiaskrgr
Rollup merge of rust-lang#116214 - notriddle:master, r=aDotInTheVoid
efc9383 
rustdoc: rename `issue-\d+.rs` tests to have meaningful names
@matthiaskrgr
Rollup merge of rust-lang#116221 - ArchUsr64:patch-1, r=ChrisDenton
ff958ae 
core/slice: Fix inconsistency between docs for `rotate_left` and `rotate_right`

A minor fix for documentation inconsistency as shown below:
## Before:
![2023_09_28_0k3_Kleki](https://github.com/rust-lang/rust/assets/83179501/569a49d3-0d72-49ac-92a2-ef5e1d94130b)
## After:
![image](https://github.com/rust-lang/rust/assets/83179501/afd0c8d7-6fb7-4878-801b-b47c8fe23c7d)
Docs url: https://doc.rust-lang.org/stable/core/primitive.slice.html#method.rotate_left
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Sep 28, 2023
@matthiaskrgr
Copy link
Member Author

@bors r+ rollup=never p=3

@bors
Copy link
Contributor

bors commented Sep 28, 2023

📌 Commit ff958ae has been approved by matthiaskrgr

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 28, 2023
@bors
Copy link
Contributor

bors commented Sep 28, 2023

⌛ Testing commit ff958ae with merge 925f844...

@bors
Copy link
Contributor

bors commented Sep 28, 2023

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing 925f844 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 28, 2023
@bors bors merged commit 925f844 into rust-lang:master Sep 28, 2023
12 checks passed
@rustbot rustbot added this to the 1.74.0 milestone Sep 28, 2023
@rust-timer
Copy link
Collaborator

📌 Perf builds for each rolled up PR:

PR# Message Perf Build Sha
#116191 Add regression test for #56098 e6233d667f5df5e7edfd5a6c7c0326471e7fb26b (link)
#116214 rustdoc: rename issue-\d+.rs tests to have meaningful nam… bd63ec96cf751e15121edc8c2916e92ef9943e29 (link)
#116221 core/slice: Fix inconsistency between docs for `rotate_left… db3de8178d08795cf73b0f800c79b0bb633bbf7f (link)

previous master: dd91aba2fd

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

@bors bors mentioned this pull request Sep 28, 2023
Open
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (925f844): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -0.9% [-1.1%, -0.6%] 2
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) -0.9% [-1.1%, -0.6%] 2

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -2.4% [-2.4%, -2.4%] 1
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) -2.4% [-2.4%, -2.4%] 1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 631.736s -> 630.455s (-0.20%)
Artifact size: 317.32 MiB -> 317.31 MiB (-0.00%)

@matthiaskrgr matthiaskrgr deleted the rollup-hi1ciwy branch March 16, 2024 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
merged-by-bors This PR was explicitly merged by bors. rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.74.0
Development

Successfully merging this pull request may close these issues.
7 participants
@matthiaskrgr @bors @rust-timer @rustbot @apekros @notriddle @ArchUsr64