Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CONTRIBUTING.md #116529

Closed
wants to merge 2 commits into from
Closed

Update CONTRIBUTING.md #116529

wants to merge 2 commits into from

Conversation

Shivanipalya26
Copy link

No description provided.

@rustbot
Copy link
Collaborator

rustbot commented Oct 8, 2023

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Mark-Simulacrum (or someone else) soon.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot rustbot added A-meta Area: Issues & PRs about the rust-lang/rust repository itself S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 8, 2023
@Rageking8
Copy link
Contributor

Merge commits are not allowed, please rebase your changes. Thanks.

@Mark-Simulacrum
Copy link
Member

r=me with commits squashed

@Mark-Simulacrum Mark-Simulacrum added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 14, 2023
@WhistlingZephyr WhistlingZephyr mentioned this pull request Nov 16, 2023
Merged
@Dylan-DPC
Copy link
Member

closing this as it has been taken care by #117980

@Dylan-DPC Dylan-DPC closed this Nov 16, 2023
@Dylan-DPC Dylan-DPC removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Nov 16, 2023
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Nov 16, 2023
@matthiaskrgr
Rollup merge of rust-lang#117980 - WhistlingZephyr:patch-1, r=Dylan-DPC
7437151 
fix: Update CONTRIBUTING.md recommend -> recommended

Redo of rust-lang#116529.
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Nov 17, 2023
@rust-timer
Unrolled build for rust-lang#117980
672cf29 
Rollup merge of rust-lang#117980 - WhistlingZephyr:patch-1, r=Dylan-DPC

fix: Update CONTRIBUTING.md recommend -> recommended

Redo of rust-lang#116529.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
A-meta Area: Issues & PRs about the rust-lang/rust repository itself
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Shivanipalya26 @rustbot @Rageking8 @Mark-Simulacrum @Dylan-DPC