Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Update CONTRIBUTING.md recommend -> recommended #117980

Merged
merged 1 commit into from
Nov 17, 2023
Merged

fix: Update CONTRIBUTING.md recommend -> recommended #117980

merged 1 commit into from
Nov 17, 2023

Conversation

WhistlingZephyr
Copy link
Contributor

Redo of #116529.

@rustbot
Copy link
Collaborator

rustbot commented Nov 16, 2023

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Mark-Simulacrum (or someone else) soon.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot rustbot added A-meta Area: Issues & PRs about the rust-lang/rust repository itself S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 16, 2023
@Dylan-DPC
Copy link
Member

thanks. this is the only occurrence of this so all good

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Nov 16, 2023

📌 Commit 4e26f9c has been approved by Dylan-DPC

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 16, 2023
@Dylan-DPC Dylan-DPC mentioned this pull request Nov 16, 2023
Closed
@matthiaskrgr matthiaskrgr mentioned this pull request Nov 16, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 17, 2023
@bors
Auto merge of rust-lang#117996 - matthiaskrgr:rollup-sp48bl4, r=matth…
f2f526c 
…iaskrgr

Rollup of 5 pull requests

Successful merges:

 - rust-lang#117892 (Detect more `=>` typos)
 - rust-lang#117959 (Better handle type errors involving `Self` literals)
 - rust-lang#117980 (fix: Update CONTRIBUTING.md recommend -> recommended)
 - rust-lang#117982 (bootstrap: only show PGO warnings when verbose)
 - rust-lang#117990 (Tweak error and move tests)

Failed merges:

 - rust-lang#117944 (some additional region refactorings)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 7437151 into rust-lang:master Nov 17, 2023
11 checks passed
@rustbot rustbot added this to the 1.76.0 milestone Nov 17, 2023
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Nov 17, 2023
@rust-timer
Unrolled build for rust-lang#117980
672cf29 
Rollup merge of rust-lang#117980 - WhistlingZephyr:patch-1, r=Dylan-DPC

fix: Update CONTRIBUTING.md recommend -> recommended

Redo of rust-lang#116529.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
A-meta Area: Issues & PRs about the rust-lang/rust repository itself S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.76.0
Development

Successfully merging this pull request may close these issues.
5 participants
@WhistlingZephyr @rustbot @Dylan-DPC @bors @Mark-Simulacrum