Require target features to match exactly during inlining #117141

tmiasko · 2023-10-24T20:50:51Z

In general it is not correct to inline a callee with a target features
that are subset of the callee. Require target features to match exactly
during inlining.

The exact match could be potentially relaxed, but this would require
identifying specific feature that are allowed to differ, those that need
to match, and those that can be present in caller but not in callee.

This resolves MIR part of #116573. For other concerns with respect to
the previous implementation also see areInlineCompatible in LLVM.

In general it is not correct to inline a callee with a target features that are subset of the callee. Require target features to match exactly during inlining. The exact match could be potentially relaxed, but this would require identifying specific feature that are allowed to differ, those that need to match, and those that can be present in caller but not in callee. This resolves MIR part of rust-lang#116573. For other concerns with respect to the previous implementation also see areInlineCompatible in LLVM.

rustbot · 2023-10-24T20:51:01Z

r? @wesleywiser

(rustbot has picked a reviewer for you, use r? to override)

rustbot · 2023-10-24T20:51:04Z

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

oli-obk · 2023-10-25T09:53:33Z

r? @oli-obk

@bors r+

bors · 2023-10-25T09:53:35Z

📌 Commit 011b260 has been approved by oli-obk

It is now in the queue for this repository.

…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#117111 (Remove support for alias `-Z instrument-coverage`) - rust-lang#117141 (Require target features to match exactly during inlining) - rust-lang#117152 (Fix unwrap suggestion for async fn) - rust-lang#117154 (implement C ABI lowering for CSKY) - rust-lang#117159 (Work around the fact that `check_mod_type_wf` may spuriously return `ErrorGuaranteed`) - rust-lang#117163 (compiletest: Display compilation errors in mir-opt tests) - rust-lang#117173 (Make `Iterator` a lang item) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#117141 - tmiasko:inline-target-features, r=oli-obk Require target features to match exactly during inlining In general it is not correct to inline a callee with a target features that are subset of the callee. Require target features to match exactly during inlining. The exact match could be potentially relaxed, but this would require identifying specific feature that are allowed to differ, those that need to match, and those that can be present in caller but not in callee. This resolves MIR part of rust-lang#116573. For other concerns with respect to the previous implementation also see areInlineCompatible in LLVM.

…ment, r=tmiasko explain why we don't inline when target features differ Follow-up to rust-lang#117141 r? `@tmiasko`

…ment, r=tmiasko explain why we don't inline when target features differ Follow-up to rust-lang#117141 r? ``@tmiasko``

Rollup merge of rust-lang#117319 - RalfJung:target-feature-inline-comment, r=tmiasko explain why we don't inline when target features differ Follow-up to rust-lang#117141 r? ``@tmiasko``

tmiasko added 3 commits October 24, 2023 22:19

Migrate inline_compatibility.rs test to FileCheck

ff7bf79

Precommit target features compatibility test

b3cfd5b

rustbot assigned wesleywiser Oct 24, 2023

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 24, 2023

rustbot assigned oli-obk and unassigned wesleywiser Oct 25, 2023

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 25, 2023

matthiaskrgr mentioned this pull request Oct 25, 2023

Rollup of 7 pull requests #117180

Merged

bors merged commit a1ab167 into rust-lang:master Oct 25, 2023
11 checks passed

rustbot added this to the 1.75.0 milestone Oct 25, 2023

tmiasko deleted the inline-target-features branch October 25, 2023 21:25

RalfJung mentioned this pull request Oct 28, 2023

explain why we don't inline when target features differ #117319

Merged

github-actions bot mentioned this pull request Oct 31, 2023

Automated pull from upstream master ferrocene/ferrocene#74

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Require target features to match exactly during inlining #117141

Require target features to match exactly during inlining #117141

tmiasko commented Oct 24, 2023

rustbot commented Oct 24, 2023

rustbot commented Oct 24, 2023

oli-obk commented Oct 25, 2023

bors commented Oct 25, 2023

Require target features to match exactly during inlining #117141

Require target features to match exactly during inlining #117141

Conversation

tmiasko commented Oct 24, 2023

rustbot commented Oct 24, 2023

rustbot commented Oct 24, 2023

oli-obk commented Oct 25, 2023

bors commented Oct 25, 2023