Fail typeck for illegal break-with-value #117382

gurry · 2023-10-30T07:36:27Z

This is fixes the issue wherein typeck was succeeding for break-with-value exprs at illegal locations such as inside while, while let and for loops which eventually caused an ICE during MIR interpretation for const eval.

Now we fail typeck for such code which prevents faulty MIR from being generated and interpreted, thus fixing the ICE.

Fixes #114529

This is fixes the issue wherein typeck was succeeding for break-with-value at illegal locations such as inside `while`, `while let` and `for` loops which eventually caused an ICE during MIR interpetation for const eval. Now we fail typeck for such code which prevents faulty MIR from being generated and interpreted, thus fixing the ICE.

rustbot · 2023-10-30T07:36:37Z

r? @wesleywiser

(rustbot has picked a reviewer for you, use r? to override)

oli-obk · 2023-10-30T08:35:28Z

Thanks!

@bors r+ rollup

bors · 2023-10-30T08:35:30Z

📌 Commit 0c8bdd0 has been approved by oli-obk

It is now in the queue for this repository.

Rollup of 8 pull requests Successful merges: - rust-lang#117147 (Print variadic argument pattern in HIR pretty printer) - rust-lang#117177 (Use ImageDataType for allocation type) - rust-lang#117205 (Allows `#[diagnostic::on_unimplemented]` attributes to have multiple) - rust-lang#117350 (coverage: Replace manual debug indents with nested tracing spans in `counters`) - rust-lang#117365 (Stabilize inline asm usage with rustc_codegen_cranelift) - rust-lang#117371 (Ignore RPIT duplicated lifetimes in `opaque_types_defined_by`) - rust-lang#117382 (Fail typeck for illegal break-with-value) - rust-lang#117385 (deduce_param_attrs: explain a read-only case) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#117382 - gurry:114529-ice-const-eval, r=oli-obk Fail typeck for illegal break-with-value This is fixes the issue wherein typeck was succeeding for break-with-value exprs at illegal locations such as inside `while`, `while let` and `for` loops which eventually caused an ICE during MIR interpretation for const eval. Now we fail typeck for such code which prevents faulty MIR from being generated and interpreted, thus fixing the ICE. Fixes rust-lang#114529

rustbot assigned wesleywiser Oct 30, 2023

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 30, 2023

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 30, 2023

fmease mentioned this pull request Oct 30, 2023

Rollup of 8 pull requests #117387

Merged

bors merged commit 4f4b38c into rust-lang:master Oct 30, 2023
11 checks passed

rustbot added this to the 1.75.0 milestone Oct 30, 2023

gurry deleted the 114529-ice-const-eval branch October 30, 2023 13:48

github-actions bot mentioned this pull request Oct 31, 2023

Automated pull from upstream master ferrocene/ferrocene#74

Merged

matthiaskrgr mentioned this pull request Nov 11, 2023

ICE: no type for local variable #117821

Closed

gurry mentioned this pull request Nov 18, 2023

Typeck break expr even if break is illegal #118010

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fail typeck for illegal break-with-value #117382

Fail typeck for illegal break-with-value #117382

gurry commented Oct 30, 2023

rustbot commented Oct 30, 2023

oli-obk commented Oct 30, 2023

bors commented Oct 30, 2023

Fail typeck for illegal break-with-value #117382

Fail typeck for illegal break-with-value #117382

Conversation

gurry commented Oct 30, 2023

rustbot commented Oct 30, 2023

oli-obk commented Oct 30, 2023

bors commented Oct 30, 2023