Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove a bunch of has_errors checks that have no meaningful or the wrong effect #120531

Merged
merged 4 commits into from
Feb 4, 2024
Merged

Remove a bunch of has_errors checks that have no meaningful or the wrong effect #120531

merged 4 commits into from
Feb 4, 2024

Conversation

oli-obk
Copy link
Contributor

@oli-obk oli-obk commented Jan 31, 2024

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 31, 2024
@estebank
Copy link
Contributor

r? @estebank

@bors r+

@bors
Copy link
Contributor

bors commented Jan 31, 2024

📌 Commit d31905c has been approved by estebank

It is now in the queue for this repository.

@rustbot rustbot assigned estebank and unassigned nnethercote Jan 31, 2024
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 31, 2024
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jan 31, 2024
@matthiaskrgr
Rollup merge of rust-lang#120531 - oli-obk:track_errors7, r=estebank
ae02de9 
Remove a bunch of `has_errors` checks that have no meaningful or the wrong effect

r? `@nnethercote`
@matthiaskrgr matthiaskrgr mentioned this pull request Jan 31, 2024
Closed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jan 31, 2024
@matthiaskrgr
Rollup merge of rust-lang#120531 - oli-obk:track_errors7, r=estebank
29ea9a1 
Remove a bunch of `has_errors` checks that have no meaningful or the wrong effect

r? ``@nnethercote``
@matthiaskrgr matthiaskrgr mentioned this pull request Jan 31, 2024
Closed
@nnethercote
Copy link
Contributor

This is good stuff. More of this will help with fixing the stash/steal soundness problem.

bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 1, 2024
@bors
Auto merge of rust-lang#120536 - matthiaskrgr:rollup-wllj7tb, r=matth…
11d66cb 
…iaskrgr

Rollup of 9 pull requests

Successful merges:

 - rust-lang#120484 (Avoid ICE when is_val_statically_known is not of a supported type)
 - rust-lang#120516 (pattern_analysis: cleanup manual impls)
 - rust-lang#120517 (never patterns: It is correct to lower `!` to `_`.)
 - rust-lang#120523 (Improve `io::Read::read_buf_exact` error case)
 - rust-lang#120528 (Store SHOULD_CAPTURE as AtomicU8)
 - rust-lang#120529 (Update data layouts in custom target tests for LLVM 18)
 - rust-lang#120530 (Be less confident when `dyn` suggestion is not checked for object safety)
 - rust-lang#120531 (Remove a bunch of `has_errors` checks that have no meaningful or the wrong effect)
 - rust-lang#120533 (Correct paths for hexagon-unknown-none-elf platform doc)

r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 3, 2024
@bors
Auto merge of rust-lang#120536 - matthiaskrgr:rollup-wllj7tb, r=matth…
5bc7414 
…iaskrgr

Rollup of 9 pull requests

Successful merges:

 - rust-lang#120484 (Avoid ICE when is_val_statically_known is not of a supported type)
 - rust-lang#120516 (pattern_analysis: cleanup manual impls)
 - rust-lang#120517 (never patterns: It is correct to lower `!` to `_`.)
 - rust-lang#120523 (Improve `io::Read::read_buf_exact` error case)
 - rust-lang#120528 (Store SHOULD_CAPTURE as AtomicU8)
 - rust-lang#120529 (Update data layouts in custom target tests for LLVM 18)
 - rust-lang#120530 (Be less confident when `dyn` suggestion is not checked for object safety)
 - rust-lang#120531 (Remove a bunch of `has_errors` checks that have no meaningful or the wrong effect)
 - rust-lang#120533 (Correct paths for hexagon-unknown-none-elf platform doc)

r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 3, 2024
@bors
Auto merge of rust-lang#120536 - matthiaskrgr:rollup-wllj7tb, r=matth…
5976d95 
…iaskrgr

Rollup of 9 pull requests

Successful merges:

 - rust-lang#120484 (Avoid ICE when is_val_statically_known is not of a supported type)
 - rust-lang#120516 (pattern_analysis: cleanup manual impls)
 - rust-lang#120517 (never patterns: It is correct to lower `!` to `_`.)
 - rust-lang#120523 (Improve `io::Read::read_buf_exact` error case)
 - rust-lang#120528 (Store SHOULD_CAPTURE as AtomicU8)
 - rust-lang#120529 (Update data layouts in custom target tests for LLVM 18)
 - rust-lang#120530 (Be less confident when `dyn` suggestion is not checked for object safety)
 - rust-lang#120531 (Remove a bunch of `has_errors` checks that have no meaningful or the wrong effect)
 - rust-lang#120533 (Correct paths for hexagon-unknown-none-elf platform doc)

r? `@ghost`
`@rustbot` modify labels: rollup
@matthiaskrgr matthiaskrgr mentioned this pull request Feb 3, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 4, 2024
@bors
Auto merge of rust-lang#120624 - matthiaskrgr:rollup-3gvcl20, r=matth…
268dbbb 
…iaskrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#120484 (Avoid ICE when is_val_statically_known is not of a supported type)
 - rust-lang#120516 (pattern_analysis: cleanup manual impls)
 - rust-lang#120517 (never patterns: It is correct to lower `!` to `_`.)
 - rust-lang#120523 (Improve `io::Read::read_buf_exact` error case)
 - rust-lang#120528 (Store SHOULD_CAPTURE as AtomicU8)
 - rust-lang#120529 (Update data layouts in custom target tests for LLVM 18)
 - rust-lang#120531 (Remove a bunch of `has_errors` checks that have no meaningful or the wrong effect)
 - rust-lang#120533 (Correct paths for hexagon-unknown-none-elf platform doc)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 7d516c5 into rust-lang:master Feb 4, 2024
10 of 11 checks passed
@rustbot rustbot added this to the 1.78.0 milestone Feb 4, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Feb 4, 2024
@rust-timer
Unrolled build for rust-lang#120531
10ea382 
Rollup merge of rust-lang#120531 - oli-obk:track_errors7, r=estebank

Remove a bunch of `has_errors` checks that have no meaningful or the wrong effect

r? `@nnethercote`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@estebank estebank

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.78.0
Development

Successfully merging this pull request may close these issues.
5 participants
@oli-obk @estebank @bors @nnethercote @rustbot