Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove a bunch of has_errors checks that have no meaningful or the wrong effect #120531

Merged
merged 4 commits into from
Feb 4, 2024
Merged

Remove a bunch of has_errors checks that have no meaningful or the wrong effect #120531

merged 4 commits into from
Feb 4, 2024

Commits on Jan 31, 2024

  1. Remove has_errors check that has no effect

    @oli-obk
    oli-obk committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    f7531f1 View commit details
    Browse the repository at this point in the history

  2. Remove a has_errors check that only hides errors after unrelated item… 

    …s have errored.
    @oli-obk
    oli-obk committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    a6b1e43 View commit details
    Browse the repository at this point in the history

  3. Remove a has_errors check that does not prevent follow up error noise

    @oli-obk
    oli-obk committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    28f250d View commit details
    Browse the repository at this point in the history

  4. Remove a has_errors check that doesn't actually prevent noisy follow … 

    …up errors
    @oli-obk
    oli-obk committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    d31905c View commit details
    Browse the repository at this point in the history