Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

For E0038, suggest associated type if available #121111

Merged
merged 1 commit into from
Feb 16, 2024
Merged

For E0038, suggest associated type if available #121111

merged 1 commit into from
Feb 16, 2024

Conversation

trevyn
Copy link
Contributor

@trevyn trevyn commented Feb 14, 2024

Closes #116434

@rustbot
Copy link
Collaborator

rustbot commented Feb 14, 2024

r? @lcnr

rustbot has assigned @lcnr.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Feb 14, 2024
@lcnr
Copy link
Contributor

lcnr commented Feb 15, 2024

r? compiler

@rustbot rustbot assigned davidtwco and unassigned lcnr Feb 15, 2024
@davidtwco
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Feb 16, 2024

📌 Commit 220e8a7 has been approved by davidtwco

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 16, 2024
@GuillaumeGomez GuillaumeGomez mentioned this pull request Feb 16, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 16, 2024
@bors
Auto merge of rust-lang#121188 - GuillaumeGomez:rollup-bejz7fq, r=Gui…
d2e8ecd 
…llaumeGomez

Rollup of 6 pull requests

Successful merges:

 - rust-lang#119928 (suggest `into_iter()` when `Iterator` method called on `impl IntoIterator`)
 - rust-lang#121020 (Avoid an ICE in diagnostics)
 - rust-lang#121111 (For E0038, suggest associated type if available)
 - rust-lang#121137 (Add clippy into the known `cfg` list)
 - rust-lang#121179 (allow mutable references in const values when they point to no memory)
 - rust-lang#121181 (Fix an ICE in the recursion lint)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 670bdbf into rust-lang:master Feb 16, 2024
11 checks passed
@rustbot rustbot added this to the 1.78.0 milestone Feb 16, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Feb 16, 2024
@rust-timer
Unrolled build for rust-lang#121111
d745c3b 
Rollup merge of rust-lang#121111 - trevyn:associated-type-suggestion, r=davidtwco

For E0038, suggest associated type if available

Closes rust-lang#116434
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidtwco davidtwco davidtwco approved these changes

Assignees

@davidtwco davidtwco

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.78.0
Development

Successfully merging this pull request may close these issues.

E0412 is correct but E0782 is emitted (in trait definitions)
5 participants
@trevyn @rustbot @lcnr @davidtwco @bors