Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 6 pull requests #121188

Merged
merged 18 commits into from
Feb 16, 2024
Merged

Rollup of 6 pull requests #121188

merged 18 commits into from
Feb 16, 2024

Conversation

GuillaumeGomez
Copy link
Member

Successful merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

d-sonuga and others added 18 commits February 12, 2024 22:11
…r-errors

suggest `into_iter()` when `Iterator` method called on `impl IntoIterator`

Fix for issue rust-lang#117711.
Avoid an ICE in diagnostics

fixes rust-lang#121004

just a slice usage in diagnostics code. Sadly we can't yet bubble the `ErrorGuaranteed` from wf check to borrowck for these cases, as that causes cycle errors iirc
… r=davidtwco

For E0038, suggest associated type if available

Closes rust-lang#116434
…rgau,Nilstrieb

Add clippy into the known `cfg` list

In clippy, we are removing the `feature = "cargo-clippy"` cfg to replace it with `clippy` in rust-lang/rust-clippy#12292. But for it to work, we need to declare `clippy` as cfg. It makes it more coherent with other existing tools like rustdoc.

cc `@flip1995`
allow mutable references in const values when they point to no memory

Fixes rust-lang#120450

The second commit is just some drive-by test suite cleanup.

r? `@oli-obk`
…_impls, r=cjgillot

Fix an ICE in the recursion lint

fixes rust-lang#121170

I looked into it, and there is no good path towards tainting mir_build (where the ICE happens), but using `try_normalize` in a lint seems generally better anyway
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Feb 16, 2024
@GuillaumeGomez
Copy link
Member Author

@bors r+ p=5 rollup=never

@bors
Copy link
Contributor

bors commented Feb 16, 2024

📌 Commit f82875e has been approved by GuillaumeGomez

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 16, 2024
@bors
Copy link
Contributor

bors commented Feb 16, 2024

⌛ Testing commit f82875e with merge d2e8ecd...

@bors
Copy link
Contributor

bors commented Feb 16, 2024

☀️ Test successful - checks-actions
Approved by: GuillaumeGomez
Pushing d2e8ecd to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Feb 16, 2024
@bors bors merged commit d2e8ecd into rust-lang:master Feb 16, 2024
12 checks passed
@rustbot rustbot added this to the 1.78.0 milestone Feb 16, 2024
@rust-timer
Copy link
Collaborator

📌 Perf builds for each rolled up PR:

PR# Message Perf Build Sha
#119928 suggest into_iter() when Iterator method called on `imp… 2cf7be506242d5fac44f162bc794c0def1a454c1 (link)
#121020 Avoid an ICE in diagnostics d06c6e946c731b2342903fbf1ae1b3d0b422f89d (link)
#121111 For E0038, suggest associated type if available d745c3b223458422c951f299a3d5693d4c062002 (link)
#121137 Add clippy into the known cfg list de72e82027d91c70f124d36be2e73e3bd7163dd8 (link)
#121179 allow mutable references in const values when they point to… 79271009579d649248562da3ddf7164fce54ae55 (link)
#121181 Fix an ICE in the recursion lint df7e13354261a051197fc6f14d54aebe899af8a8 (link)

previous master: ae9d7b0c64

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (d2e8ecd): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
0.5% [0.4%, 0.7%] 6
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
4.5% [4.5%, 4.5%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
2.5% [2.5%, 2.5%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 638.61s -> 639.468s (0.13%)
Artifact size: 306.35 MiB -> 306.35 MiB (-0.00%)

@GuillaumeGomez GuillaumeGomez deleted the rollup-bejz7fq branch February 17, 2024 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants