Rename inhibit_union_abi_opt() to inhibits_union_abi_opt()
#124463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The present tense makes it read more naturally at use site i.e. "this repr _inhibits_ optimizations"
rustbot
added
S-waiting-on-review
fmease
changed the title
inihibit_union_abi_opt() to inihibits_union_abi_opt()inhibit_union_abi_opt() to inhibits_union_abi_opt()
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 28, 2024
…iaskrgr Rollup of 2 pull requests Successful merges: - rust-lang#124444 (Record certainty of `evaluate_added_goals_and_make_canonical_response` call in candidate) - rust-lang#124463 (Rename `inhibit_union_abi_opt()` to `inhibits_union_abi_opt()`) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 28, 2024
Rollup merge of rust-lang#124463 - gurry:rename-func, r=TaKO8Ki Rename `inhibit_union_abi_opt()` to `inhibits_union_abi_opt()` `inihibit` seems to suggest that this function will inhibit optimizations whereas `inhibits` correctly indicates that it will merely _check_ that. With `inhibits` if conditions read more naturally e.g.: ```rust if repr.inhibits_union_abi_opt() { } ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
inihibitseems to suggest that this function will inhibit optimizations whereasinhibitscorrectly indicates that it will merely check that. Withinhibitsif conditions read more naturally e.g.: