Rollup of 2 pull requests #124467
Rollup of 2 pull requests #124467
Conversation
…call in candidate
The present tense makes it read more naturally at use site i.e. "this repr _inhibits_ optimizations"
Record certainty of `evaluate_added_goals_and_make_canonical_response` call in candidate Naming subject to bikeshedding, but I will need this when moving `select` to a proof tree visitor. r? lcnr
Rename `inhibit_union_abi_opt()` to `inhibits_union_abi_opt()`
`inihibit` seems to suggest that this function will inhibit optimizations whereas `inhibits` correctly indicates that it will merely _check_ that. With `inhibits` if conditions read more naturally e.g.:
```rust
if repr.inhibits_union_abi_opt() {
}
```
rustbot
added
S-waiting-on-review
|
@bors r+ rollup=never p=2 |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
|
📌 Perf builds for each rolled up PR:
previous master: ba00750418 In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
|
Finished benchmarking commit (ce609db): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 673.808s -> 673.364s (-0.07%) |
Successful merges:
evaluate_added_goals_and_make_canonical_responsecall in candidate #124444 (Record certainty ofevaluate_added_goals_and_make_canonical_responsecall in candidate)inhibit_union_abi_opt()toinhibits_union_abi_opt()#124463 (Renameinhibit_union_abi_opt()toinhibits_union_abi_opt())r? @ghost
@rustbot modify labels: rollup
Create a similar rollup