Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix read_exact and read_buf_exact for &[u8] and io:Cursor #125123

Merged
merged 2 commits into from
May 21, 2024
Merged

Fix read_exact and read_buf_exact for &[u8] and io:Cursor #125123

merged 2 commits into from
May 21, 2024

Conversation

a1phyr
Copy link
Contributor

@a1phyr a1phyr commented May 14, 2024

  • Drain after read_exact and read_buf_exact
  • Append to cursor in read_buf_exact

@rustbot
Copy link
Collaborator

rustbot commented May 14, 2024

r? @workingjubilee

rustbot has assigned @workingjubilee.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels May 14, 2024
workingjubilee
workingjubilee reviewed May 15, 2024
View reviewed changes
library/std/src/io/cursor.rs Outdated Show resolved Hide resolved
library/std/src/io/cursor.rs Show resolved Hide resolved
library/std/src/io/cursor.rs Show resolved Hide resolved
library/std/src/io/impls.rs Show resolved Hide resolved
library/std/src/io/impls.rs Show resolved Hide resolved
@a1phyr
Copy link
Contributor Author

a1phyr commented May 20, 2024

I've added tests for the exact behavior of the readers on EOF.

I don't think that doctests are useful here so I've added normal unit tests instead. Please tell me if you think that we doctests are what we really need.

@workingjubilee
Copy link
Member

hmm, that's fine by me!

@bors r+

@bors
Copy link
Contributor

bors commented May 20, 2024

📌 Commit a197ff3 has been approved by workingjubilee

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 20, 2024
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request May 20, 2024
@matthiaskrgr
Rollup merge of rust-lang#125123 - a1phyr:fix-read_exact, r=workingju…
6586ed7 
…bilee

Fix `read_exact` and `read_buf_exact` for `&[u8]` and `io:Cursor`

- Drain after `read_exact` and `read_buf_exact`
- Append to cursor in `read_buf_exact`
@matthiaskrgr matthiaskrgr mentioned this pull request May 20, 2024
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request May 20, 2024
@bors
Auto merge of rust-lang#125344 - matthiaskrgr:rollup-l2ujf69, r=matth…
e411e7a 
…iaskrgr

Rollup of 6 pull requests

Successful merges:

 - rust-lang#124050 (Remove libc from MSVC targets)
 - rust-lang#124283 (Note for E0599 if shadowed bindings has the method.)
 - rust-lang#125123 (Fix `read_exact` and `read_buf_exact` for `&[u8]` and `io:Cursor`)
 - rust-lang#125158 (hir pretty: fix block indent)
 - rust-lang#125298 (Add codegen test for array comparision opt)
 - rust-lang#125332 (Update books)

Failed merges:

 - rust-lang#125310 (Move ~100 tests from tests/ui to subdirs)

r? `@ghost`
`@rustbot` modify labels: rollup
@matthiaskrgr matthiaskrgr mentioned this pull request May 20, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request May 21, 2024
@bors
Auto merge of rust-lang#125349 - matthiaskrgr:rollup-p2mbdxi, r=matth…
8e7517d 
…iaskrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#124050 (Remove libc from MSVC targets)
 - rust-lang#124283 (Note for E0599 if shadowed bindings has the method.)
 - rust-lang#125123 (Fix `read_exact` and `read_buf_exact` for `&[u8]` and `io:Cursor`)
 - rust-lang#125158 (hir pretty: fix block indent)
 - rust-lang#125308 (track cycle participants per root)
 - rust-lang#125332 (Update books)
 - rust-lang#125333 (switch to the default implementation of `write_vectored`)
 - rust-lang#125346 (Remove some `Path::to_str` from `rustc_codegen_llvm`)

Failed merges:

 - rust-lang#125310 (Move ~100 tests from tests/ui to subdirs)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 62da957 into rust-lang:master May 21, 2024
6 checks passed
@rustbot rustbot added this to the 1.80.0 milestone May 21, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request May 21, 2024
@rust-timer
Unrolled build for rust-lang#125123
67b37f5 
Rollup merge of rust-lang#125123 - a1phyr:fix-read_exact, r=workingjubilee

Fix `read_exact` and `read_buf_exact` for `&[u8]` and `io:Cursor`

- Drain after `read_exact` and `read_buf_exact`
- Append to cursor in `read_buf_exact`
@eric-seppanen eric-seppanen mentioned this pull request Aug 2, 2024
Open
@minghuaw minghuaw mentioned this pull request Aug 6, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@workingjubilee workingjubilee workingjubilee left review comments

Assignees

@workingjubilee workingjubilee

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.80.0
Development

Successfully merging this pull request may close these issues.
4 participants
@a1phyr @rustbot @workingjubilee @bors