Rollup of 8 pull requests #125349

matthiaskrgr · 2024-05-20T22:47:05Z

Successful merges:

Remove libc from MSVC targets #124050 (Remove libc from MSVC targets)
Note for E0599 if shadowed bindings has the method. #124283 (Note for E0599 if shadowed bindings has the method.)
Fix read_exact and read_buf_exact for &[u8] and io:Cursor #125123 (Fix read_exact and read_buf_exact for &[u8] and io:Cursor)
hir pretty: fix block indent #125158 (hir pretty: fix block indent)
track cycle participants per root #125308 (track cycle participants per root)
Update books #125332 (Update books)
switch to the default implementation of write_vectored #125333 (switch to the default implementation of write_vectored)
Remove some Path::to_str from rustc_codegen_llvm #125346 (Remove some Path::to_str from rustc_codegen_llvm)

Failed merges:

Move ~100 tests from tests/ui to subdirs #125310 (Move ~100 tests from tests/ui to subdirs)

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

implement rust-lang#123558

Unnecessary panic paths when there's a better option.

…sDenton Remove libc from MSVC targets ``@ChrisDenton`` started working on a project to remove libc from Windows MSVC targets. I'm completing that work here. The primary change is to cfg out the dependency in `library/`. And then there's a lot of test patching. Happy to separate this more if people want.

Note for E0599 if shadowed bindings has the method. implement rust-lang#123558 Use a visitor to find earlier shadowed bingings which has the method. r? ``@estebank``

…bilee Fix `read_exact` and `read_buf_exact` for `&[u8]` and `io:Cursor` - Drain after `read_exact` and `read_buf_exact` - Append to cursor in `read_buf_exact`

…-errors hir pretty: fix block indent before: ```rust fn main() { { { ::std::io::_print(format_arguments::new_const(&["Hello, world!\n"])); }; } } ``` after: ```rust fn main() { { { ::std::io::_print(format_arguments::new_const(&["Hello, world!\n"])); }; } } ``` AST pretty does the same.

…rors track cycle participants per root The search graph may have multiple roots, e.g. in ``` A :- B B :- A, C C :- D D :- C ``` we first encounter the `A -> B -> A` cycle which causes `A` to be a root. We then later encounter the `C -> D -> C` cycle as a nested goal of `B`. This cycle is completely separate and `C` will get moved to the global cache. This previously caused us to use `[B, D]` as the `cycle_participants` for `C` and `[]` for `A`. split off from rust-lang#125167 as I would like to merge this change separately and will rebase that PR on top of this one. There is no test for this issue and I don't quite know how to write one. It is probably worth it to generalize the search graph to enable us to write unit tests for it. r? `@compiler-errors`

Update books ## rust-lang/book 8 commits in bebcf527e67755a989a1739b7cfaa8f0e6b30040..5e9051f71638aa941cd5dda465e25c61cde9594f 2024-05-16 14:58:56 UTC to 2024-05-07 23:58:22 UTC - Convert ch01-03-hello-cargo.md Listing 1-2 using `<Listing>` (rust-lang/book#3924) - infra: fix rendering bug in mdbook-trpl-note (rust-lang/book#3925) - infra: support `Listing`s without `file-name` (rust-lang/book#3920) - Add a `<Listing>` preprocessor (rust-lang/book#3918) - Update explanation according to code listing (rust-lang/book#3916) - infra: run package tests (rust-lang/book#3915) - Fix workspace behavior by excluding `listings` (rust-lang/book#3914) - Backport changes to chapter 8 (rust-lang/book#3913) ## rust-embedded/book 1 commits in 17842ebb050f62e40a4618edeb8e8ee86e758707..dd962bb82865a5284f2404e5234f1e3222b9c022 2024-05-17 23:43:59 UTC to 2024-05-17 23:43:59 UTC - 'llvm-tools-preview' component is now named 'llvm-tools' (rust-embedded/book#372) ## rust-lang/reference 2 commits in 51817951d0d213a0011f82b62aae02c3b3f2472e..e356977fceaa8591c762312d8d446769166d4b3e 2024-05-10 12:49:15 UTC to 2024-05-07 13:32:57 UTC - Document inline const/const block expression (rust-lang/reference#1295) - patterns: include yet unstable exclusive range patterns (rust-lang/reference#1484) ## rust-lang/rust-by-example 7 commits in 229ad13b64d919b12e548d560f06d88963b25cd3..20482893d1a502df72f76762c97aed88854cdf81 2024-05-20 14:36:21 UTC to 2024-05-14 16:17:03 UTC - Clarify interchangability for From and Into (rust-lang/rust-by-example#1851) - Update ja.po based on the latest master (rust-lang/rust-by-example#1850) - Add explicit section link (rust-lang/rust-by-example#1847) - Adjust translation build on CI (rust-lang/rust-by-example#1849) - Update mdbook version in CI (rust-lang/rust-by-example#1848) - Fix some broken links in ja.po (rust-lang/rust-by-example#1844) - Fix an external link to absolute (rust-lang/rust-by-example#1842) ## rust-lang/rustc-dev-guide 8 commits in 2d1947f..b6d4a49 2024-05-17 17:04:58 UTC to 2024-05-09 13:22:03 UTC - Add a high level explanation of early/late bound params (rust-lang/rustc-dev-guide#1982) - Fix broken link to "Lowering" (rust-lang/rustc-dev-guide#1981) - Broken link fix (rust-lang/rustc-dev-guide#1980) - Add note about how to pick up abandoned PRs (rust-lang/rustc-dev-guide#1977) - Toc here is overkill (rust-lang/rustc-dev-guide#1976) - Link to lint `L-*` labels (rust-lang/rustc-dev-guide#1975) - Update the rustc_interface examples for current rustc (rust-lang/rustc-dev-guide#1974) - Edit `Parameter Environments`'s url as it has been edited in rust-lang#1953 (rust-lang/rustc-dev-guide#1973)

switch to the default implementation of `write_vectored` HermitOS doesn't support write_vectored and switch to the default implementation of `write_vectored`.

Remove some `Path::to_str` from `rustc_codegen_llvm` Unnecessary panic paths when there's a better option.

matthiaskrgr · 2024-05-20T22:47:24Z

@bors r+ rollup=never p=8

bors · 2024-05-20T22:47:27Z

📌 Commit 63fa01e has been approved by matthiaskrgr

It is now in the queue for this repository.

bors · 2024-05-21T00:46:34Z

⌛ Testing commit 63fa01e with merge 8e7517d...

bors · 2024-05-21T02:50:31Z

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing 8e7517d to master...

rust-timer · 2024-05-21T02:52:44Z

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#124050	Remove libc from MSVC targets	`480391d9dce9ea29298e2de62cfd8e0f8272e4de` (link)
#124283	Note for E0599 if shadowed bindings has the method.	`888e925223538b97f0d55b7aaec07159a848209d` (link)
#125123	Fix `read_exact` and `read_buf_exact` for `&[u8]` and `io:C…	`67b37f5054e4508694b7bd0b766e27f64cbd2d7f` (link)
#125158	hir pretty: fix block indent	`a3ebab671825cbad2f94c3dd0ee1235e00d6d59f` (link)
#125308	track cycle participants per root	`f587b639b7ea03e7b0969eba6a29cae4e3ec1153` (link)
#125332	Update books	`25e6232bd4f936f7dc79864c03e0325f452adcab` (link)
#125333	switch to the default implementation of `write_vectored`	`7dffa1720650dcc47d50f11f9d69af550d3af395` (link)
#125346	Remove some `Path::to_str` from `rustc_codegen_llvm`	`43ff5b4a8d9d488abcaf6212d664e514d93723d8` (link)

previous master: 60faa271d9

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

rust-timer · 2024-05-21T04:06:18Z

Finished benchmarking commit (8e7517d): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.5%	[-0.7%, -0.4%]	2
Improvements ✅ (secondary)	-0.2%	[-0.2%, -0.2%]	1
All ❌✅ (primary)	-0.5%	[-0.7%, -0.4%]	2

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results (primary -1.1%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-1.1%	[-1.5%, -0.8%]	3
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-1.1%	[-1.5%, -0.8%]	3

Binary size

Results (primary -0.1%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.2%	[0.0%, 0.2%]	5
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.3%	[-1.2%, -0.0%]	4
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-0.1%	[-1.2%, 0.2%]	9

Bootstrap: 675.351s -> 671.714s (-0.54%)
Artifact size: 315.41 MiB -> 315.43 MiB (0.00%)

a1phyr and others added 29 commits May 14, 2024 16:16

Fix read_exact and read_buf_exact for &[u8] and io:Cursor

cfb0479

Note for E0599 if shadowed bindings has the method.

b092b5d

implement rust-lang#123558

Address review comments

a197ff3

Fix up a few more tests

8d3bc55

Add only-unix to sigpipe tests

e0632d7

Handle a few more simple tests

18b0a07

Add a Windows version of foreign2.rs

281178d

Patch up foreign-fn-linkname.rs

70147cd

Port stdout-during-shutdown

7a906e1

Fix feature-gates/rustc-private.rs

f45a7a2

Update tests/incremental/foreign.rs

30379f9

Remove Windows dependency on libc

aa31281

Undo accidental change to tests/ui/sanitizer/thread.rs

39ef149

Update books

ba8fba9

switch to the default implementation of write_vectored

c170bf9

hir pretty: fix block indent

7b1527f

switch also the default implementation for read_vectored

d39dc0a

move fixpoint step into subfunction

82df0c3

move global cache lookup into fn

ee0f20b

track cycle participants per entry

f99c9ff

Remove some Path::to_str from rustc_codegen_llvm

fa1b7f2

Unnecessary panic paths when there's a better option.

Rollup merge of rust-lang#124283 - surechen:fix_123558, r=estebank

e275d2d

Note for E0599 if shadowed bindings has the method. implement rust-lang#123558 Use a visitor to find earlier shadowed bingings which has the method. r? ``@estebank``

Rollup merge of rust-lang#125123 - a1phyr:fix-read_exact, r=workingju…

62da957

…bilee Fix `read_exact` and `read_buf_exact` for `&[u8]` and `io:Cursor` - Drain after `read_exact` and `read_buf_exact` - Append to cursor in `read_buf_exact`

Rollup merge of rust-lang#125333 - hermit-os:fuse, r=workingjubilee

73bb47e

switch to the default implementation of `write_vectored` HermitOS doesn't support write_vectored and switch to the default implementation of `write_vectored`.

Rollup merge of rust-lang#125346 - tbu-:pr_rm_path_to_str, r=wesleywiser

63fa01e

Remove some `Path::to_str` from `rustc_codegen_llvm` Unnecessary panic paths when there's a better option.

rustbot added the O-hermit Operating System: Hermit label May 20, 2024

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 20, 2024

bors added the merged-by-bors This PR was explicitly merged by bors. label May 21, 2024

bors merged commit 8e7517d into rust-lang:master May 21, 2024
7 checks passed

rustbot added this to the 1.80.0 milestone May 21, 2024

bors mentioned this pull request May 21, 2024

Replace io::Cursor::{remaining_slice, is_empty} #109174

Merged

matthiaskrgr deleted the rollup-p2mbdxi branch September 1, 2024 17:35

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rollup of 8 pull requests #125349

Rollup of 8 pull requests #125349

matthiaskrgr commented May 20, 2024

matthiaskrgr commented May 20, 2024

bors commented May 20, 2024

bors commented May 21, 2024

bors commented May 21, 2024

rust-timer commented May 21, 2024

rust-timer commented May 21, 2024

Rollup of 8 pull requests #125349

Rollup of 8 pull requests #125349

Conversation

matthiaskrgr commented May 20, 2024

matthiaskrgr commented May 20, 2024

bors commented May 20, 2024

bors commented May 21, 2024

bors commented May 21, 2024

rust-timer commented May 21, 2024

rust-timer commented May 21, 2024

Overall result: ✅ improvements - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size