Add a hook for should_codegen_locally
#127779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
momvart
force-pushed
the
should_codegen_hook
branch
from
34fc498 to
d3cc29a
Compare
This comment has been minimized.
This comment has been minimized.
momvart
force-pushed
the
should_codegen_hook
branch
from
d3cc29a to
745fe57
Compare
|
Some changes occurred in compiler/rustc_codegen_cranelift cc @bjorn3 |
This comment has been minimized.
This comment has been minimized.
momvart
changed the title
should_codegen_locallyshould_codegen_locally
momvart
changed the title
should_codegen_locallyshould_codegen_locally
momvart
force-pushed
the
should_codegen_hook
branch
from
745fe57 to
9b80250
Compare
|
@bors try @rust-timer queue |
This comment has been minimized.
This comment has been minimized.
rustbot
added
the
S-waiting-on-perf
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 19, 2024
Add a hook for `should_codegen_locally` This PR lifts the module-local function `should_codegen_locally` to `TyCtxt` as a hook. In addition to monomorphization, this function is used for checking the dependency of `compiler_builtins` on other libraries. Moving this function to the hooks also makes overriding it possible for the tools that use the rustc interface.
|
☀️ Try build successful - checks-actions |
This comment has been minimized.
This comment has been minimized.
|
Finished benchmarking commit (071bac7): comparison URL. Overall result: ❌ regressions - no action neededBenchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf. @bors rollup=never Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)This benchmark run did not return any relevant results for this metric. CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 767.644s -> 770.693s (0.40%) |
rustbot
removed
the
S-waiting-on-perf
|
@bors r+ rollup- |
bors
removed
the
S-waiting-on-review
bors
added
the
S-waiting-on-bors
tgross35
added a commit
to tgross35/rust
that referenced
this pull request
Jul 20, 2024
…illot Add a hook for `should_codegen_locally` This PR lifts the module-local function `should_codegen_locally` to `TyCtxt` as a hook. In addition to monomorphization, this function is used for checking the dependency of `compiler_builtins` on other libraries. Moving this function to the hooks also makes overriding it possible for the tools that use the rustc interface.
tgross35
added a commit
to tgross35/rust
that referenced
this pull request
Jul 20, 2024
…illot Add a hook for `should_codegen_locally` This PR lifts the module-local function `should_codegen_locally` to `TyCtxt` as a hook. In addition to monomorphization, this function is used for checking the dependency of `compiler_builtins` on other libraries. Moving this function to the hooks also makes overriding it possible for the tools that use the rustc interface.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 20, 2024
…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#127463 ( use precompiled rustdoc with CI rustc) - rust-lang#127779 (Add a hook for `should_codegen_locally`) - rust-lang#127843 (unix: document unsafety for std `sig{action,altstack}`) - rust-lang#127873 (kmc-solid: `#![forbid(unsafe_op_in_unsafe_fn)]`) - rust-lang#127917 (match lowering: Split `finalize_or_candidate` into more coherent methods) - rust-lang#127964 (run_make_support: skip rustfmt for lib.rs) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 20, 2024
Rollup merge of rust-lang#127779 - momvart:should_codegen_hook, r=cjgillot Add a hook for `should_codegen_locally` This PR lifts the module-local function `should_codegen_locally` to `TyCtxt` as a hook. In addition to monomorphization, this function is used for checking the dependency of `compiler_builtins` on other libraries. Moving this function to the hooks also makes overriding it possible for the tools that use the rustc interface.
bjorn3
pushed a commit
to bjorn3/rust
that referenced
this pull request
Aug 9, 2024
…illot Add a hook for `should_codegen_locally` This PR lifts the module-local function `should_codegen_locally` to `TyCtxt` as a hook. In addition to monomorphization, this function is used for checking the dependency of `compiler_builtins` on other libraries. Moving this function to the hooks also makes overriding it possible for the tools that use the rustc interface.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR lifts the module-local function
should_codegen_locallytoTyCtxtas a hook.In addition to monomorphization, this function is used for checking the dependency of
compiler_builtinson other libraries. Moving this function to the hooks also makes overriding it possible for the tools that use the rustc interface.