run_make_support: skip rustfmt for lib.rs #127964
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
A-run-make
nnethercote
reviewed
Jul 19, 2024
| pub use external_deps::{c_build, cc, clang, htmldocck, llvm, python, rustc, rustdoc}; | ||
|
|
||
| // These rely on external dependencies. | ||
| #[rustfmt::skip] | ||
| pub use c_build::build_native_static_lib; | ||
| pub use cc::{cc, extra_c_flags, extra_cxx_flags, Cc}; | ||
| pub use clang::{clang, Clang}; |
There was a problem hiding this comment.
There are more comments and blank lines below here. All of the comments apply to single lines, so no comments will end up on incorrect places. But ordering will be changed and blank lines removed. Given that this file mostly contains use declaration, it might just be better to add a single #![rustfmt::skip] at the top to inhibit formatting of the entire file. This was done for a few files in #126776.
There was a problem hiding this comment.
Done, just slapped a #![cfg_attr(rustfmt, rustfmt::skip)] to the lib.rs file.
rust-cloud-vms
bot
force-pushed
the
rmake-rustfmt-skip
branch
from
47cb497 to
36ebf7a
Compare
|
@bors r+ |
bors
added
S-waiting-on-bors
|
@bors rollup |
jieyouxu
changed the title
#[rustfmt::skip] barriers to comments for use groups
tgross35
added a commit
to tgross35/rust
that referenced
this pull request
Jul 20, 2024
…thercote run_make_support: skip rustfmt for lib.rs To avoid them getting reordered once rust-lang#125443 goes through. r? `@nnethercote` (since you were working on this)
tgross35
added a commit
to tgross35/rust
that referenced
this pull request
Jul 20, 2024
…thercote run_make_support: skip rustfmt for lib.rs To avoid them getting reordered once rust-lang#125443 goes through. r? ```@nnethercote``` (since you were working on this)
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 20, 2024
…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#127463 ( use precompiled rustdoc with CI rustc) - rust-lang#127779 (Add a hook for `should_codegen_locally`) - rust-lang#127843 (unix: document unsafety for std `sig{action,altstack}`) - rust-lang#127873 (kmc-solid: `#![forbid(unsafe_op_in_unsafe_fn)]`) - rust-lang#127917 (match lowering: Split `finalize_or_candidate` into more coherent methods) - rust-lang#127964 (run_make_support: skip rustfmt for lib.rs) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 20, 2024
Rollup merge of rust-lang#127964 - jieyouxu:rmake-rustfmt-skip, r=nnethercote run_make_support: skip rustfmt for lib.rs To avoid them getting reordered once rust-lang#125443 goes through. r? ``@nnethercote`` (since you were working on this)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid them getting reordered once #125443 goes through.
r? @nnethercote (since you were working on this)