-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate emit-to-stdout
run-make
test to rmake
#128460
Conversation
This comment has been minimized.
This comment has been minimized.
Note to self: look at the pseudoterminal stuff |
Note that the test does not necessarily need |
Btw, on windows this can be done via |
Progress update: none, since I haven't gotten to this one yet, lol |
5a9a84d
to
73560f5
Compare
73560f5
to
47e9643
Compare
The job Click to see the possible cause of the failure (guessed by this bot)
|
Review notes: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion: rename this test to rustc-emit-to-stdout
or something, since apparently there's a emit-shared-files
test which is exercising rustdoc only (where I suggested to rename that test to rustdoc-emit-shared-files
as well).
Here's my (very quick) implementation that might work on Linux. I've not tested it though. df8d4ba It works on Windows but note the "fixme". |
Closing this in favor of #131355 where we consolidated all of the efforts for |
Part of #121876 and the associated Google Summer of Code project.
Another test which will fail CI. Most of everything here works, with the only exception being the cases where the test redirects stdout to a tty:
1>/dev/ptmx
.run_make_support
doesn't support this yet, so I am posting this PR to open a discussion.