Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for some old fixed issues #131355

Merged
merged 6 commits into from
Oct 8, 2024
Merged

Add tests for some old fixed issues #131355

merged 6 commits into from
Oct 8, 2024

Conversation

clubby789
Copy link
Contributor

@clubby789 clubby789 commented Oct 7, 2024 •
edited by jieyouxu
Loading

Closes #30867
Closes #30472
Closes #28994
Closes #26719 (and migrates the relevant test to the new run-make)
Closes #23600

cc @jieyouxu for the run-make-support changes

try-job: x86_64-msvc

@rustbot
Copy link
Collaborator

rustbot commented Oct 7, 2024

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-run-make Area: port run-make Makefiles to rmake.rs A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 7, 2024
@rustbot
Copy link
Collaborator

rustbot commented Oct 7, 2024

This PR modifies tests/run-make/. If this PR is trying to port a Makefile
run-make test to use rmake.rs, please update the
run-make port tracking issue
so we can track our progress. You can either modify the tracking issue
directly, or you can comment on the tracking issue and link this PR.

cc @jieyouxu

The run-make-support library was changed

cc @jieyouxu

jieyouxu
jieyouxu requested changes Oct 7, 2024
View reviewed changes
Copy link
Member

@jieyouxu jieyouxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I left some suggestions.

src/tools/run-make-support/src/external_deps/rustc.rs Outdated Show resolved Hide resolved
tests/run-make/emit-to-stdout/rmake.rs Outdated Show resolved Hide resolved
tests/run-make/emit-to-stdout/rmake.rs Outdated Show resolved Hide resolved
tests/ui/consts/issue-77062-large-zst-array.rs Outdated Show resolved Hide resolved
tests/ui/traits/assoc-type-hrtb-normalization-30472.rs Show resolved Hide resolved
tests/ui/traits/fn-pointer/hrtb-assoc-fn-traits-28994.rs Show resolved Hide resolved
tests/ui/traits/hrtb-related-type-params-30867.rs Show resolved Hide resolved
tests/run-make/emit-to-stdout/rmake.rs Show resolved Hide resolved
@jieyouxu jieyouxu assigned jieyouxu and unassigned Mark-Simulacrum Oct 7, 2024
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@jieyouxu
Copy link
Member

jieyouxu commented Oct 7, 2024

@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 7, 2024
@clubby789
Copy link
Contributor Author

@bors try

bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 7, 2024
@bors
Auto merge of rust-lang#131355 - clubby789:old-tests, r=<try>
a0df115 
Add tests for some old fixed issues

Closes rust-lang#30867
Closes rust-lang#30472
Closes rust-lang#28994
Closes rust-lang#26719 (and migrates the relevant test to the new run-make)
Closes rust-lang#23600

cc `@jieyouxu` for the run-make-support changes

try-job: x86_64-msvc
@bors
Copy link
Contributor

bors commented Oct 7, 2024

⌛ Trying commit 382365b with merge a0df115...

@bors
Copy link
Contributor

bors commented Oct 8, 2024

☀️ Try build successful - checks-actions
Build commit: a0df115 (a0df1154b857209528b968ce7844150f753405fc)

jieyouxu
jieyouxu approved these changes Oct 8, 2024
View reviewed changes
Copy link
Member

@jieyouxu jieyouxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jieyouxu
Copy link
Member

jieyouxu commented Oct 8, 2024

@bors r+ rollup=iffy (run-make test that exercises platform-specific rustc standard stream behaviors)

@bors
Copy link
Contributor

bors commented Oct 8, 2024

📌 Commit 382365b has been approved by jieyouxu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 8, 2024
@jieyouxu jieyouxu mentioned this pull request Oct 8, 2024
Closed
@Zalathar Zalathar mentioned this pull request Oct 8, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 8, 2024
@bors
Auto merge of rust-lang#131387 - Zalathar:rollup-kprp512, r=Zalathar
e6c46db 
Rollup of 7 pull requests

Successful merges:

 - rust-lang#130824 (Add missing module flags for `-Zfunction-return=thunk-extern`)
 - rust-lang#131170 (Fix `target_vendor` in non-IDF Xtensa ESP32 targets)
 - rust-lang#131355 (Add tests for some old fixed issues)
 - rust-lang#131369 (Update books)
 - rust-lang#131370 (rustdoc: improve `<wbr>`-insertion for SCREAMING_CAMEL_CASE)
 - rust-lang#131379 (Fix utf8-bom test)
 - rust-lang#131385 (Un-vacation myself)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit cc5a24c into rust-lang:master Oct 8, 2024
7 checks passed
@rustbot rustbot added this to the 1.83.0 milestone Oct 8, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Oct 8, 2024
@rust-timer
Unrolled build for rust-lang#131355
e2fa645 
Rollup merge of rust-lang#131355 - clubby789:old-tests, r=jieyouxu

Add tests for some old fixed issues

Closes rust-lang#30867
Closes rust-lang#30472
Closes rust-lang#28994
Closes rust-lang#26719 (and migrates the relevant test to the new run-make)
Closes rust-lang#23600

cc `@jieyouxu` for the run-make-support changes

try-job: x86_64-msvc
@Kobzol Kobzol mentioned this pull request Oct 8, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jieyouxu jieyouxu jieyouxu approved these changes

Assignees

@jieyouxu jieyouxu

Labels
A-run-make Area: port run-make Makefiles to rmake.rs A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
Oxidizing run-make tests
Status: Done
Milestone
1.83.0
6 participants
@clubby789 @rustbot @rust-log-analyzer @jieyouxu @bors @Mark-Simulacrum