-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rustdoc: rename issue-\d+.rs
tests to have meaningful names (part 9)
#130287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot has assigned @Mark-Simulacrum. Use |
rustbot
added
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-rustdoc
Relevant to the rustdoc team, which will review and decide on the PR/issue.
labels
Sep 12, 2024
jieyouxu
approved these changes
Sep 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
@bors r+ rollup |
bors
added
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Sep 12, 2024
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 13, 2024
Rollup of 3 pull requests Successful merges: - rust-lang#130245 (make basic allocation functions track_caller in Miri for nicer backtraces) - rust-lang#130261 (skip target sanity check when it's a `local-rebuild`) - rust-lang#130287 (rustdoc: rename `issue-\d+.rs` tests to have meaningful names (part 9)) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 13, 2024
Rollup merge of rust-lang#130287 - notriddle:notriddle/issue-d, r=jieyouxu rustdoc: rename `issue-\d+.rs` tests to have meaningful names (part 9) Follow up * rust-lang#116214 * rust-lang#116432 * rust-lang#116824 * rust-lang#118105 * rust-lang#119561 * rust-lang#123574 * rust-lang#125382 * rust-lang#127671 As always, it's easier to review the commits one at a time. Don't use the Files Changed tab. It's confusing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
T-rustdoc
Relevant to the rustdoc team, which will review and decide on the PR/issue.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up
issue-\d+.rs
tests to have meaningful names #116214issue-\d+.rs
tests to have meaningful names (part 2) #116432issue-\d+.rs
tests to have meaningful names (part 3) #116824issue-\d+.rs
tests to have meaningful names (part 4) #118105issue-\d+.rs
tests to have meaningful names (part 5) #119561issue-\d+.rs
tests to have meaningful names (part 6) #123574issue-\d+.rs
tests to have meaningful names (part 7) #125382issue-\d+.rs
tests to have meaningful names (part 8) #127671As always, it's easier to review the commits one at a time. Don't use the Files Changed tab. It's confusing.