Apple: Avoid redundant -Wl,-dylib flag when linking
#131479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @chenyukang rustbot has assigned @chenyukang. Use |
rustbot
added
S-waiting-on-review
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 10, 2024
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#130625 (Fix a few relative paths in rustc doc) - rust-lang#131397 (fix/update teach_note from 'escaping mutable ref/ptr' const-check) - rust-lang#131479 (Apple: Avoid redundant `-Wl,-dylib` flag when linking) - rust-lang#131480 (Fix hardcoded strip path when cross-compiling from Linux to Darwin) - rust-lang#131482 (structurally resolve adts and tuples expectations too) - rust-lang#131484 (Add myself back to review rotation) - rust-lang#131491 (impossible obligations fast path) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 10, 2024
Rollup merge of rust-lang#131479 - madsmtm:avoid-redundant-dylib, r=jieyouxu Apple: Avoid redundant `-Wl,-dylib` flag when linking Seems to have been introduced all the way back in rust-lang@e338a41, but should be redundant, `-dynamiclib` should already make `cc` set `-dylib` when linking. Spotted this while trying to get `-Clinker-flavor=gcc` and `-Clinker-flavor=ld` closer together, not that important to fix. `@rustbot` label O-apple
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems to have been introduced all the way back in e338a41, but should be redundant,
-dynamiclibshould already makeccset-dylibwhen linking.Spotted this while trying to get
-Clinker-flavor=gccand-Clinker-flavor=ldcloser together, not that important to fix.@rustbot label O-apple