Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix various linker warnings #132244

Merged
merged 4 commits into from
Oct 28, 2024
Merged

fix various linker warnings #132244

merged 4 commits into from
Oct 28, 2024

Conversation

jyn514
Copy link
Member

@jyn514 jyn514 commented Oct 28, 2024

separated out from #119286; this doesn't have anything user-facing, i just want to land these changes so i can stop rebasing them.

r? @bjorn3

@rustbot rustbot added A-compiletest Area: The compiletest test runner A-run-make Area: port run-make Makefiles to rmake.rs A-testsuite Area: The testsuite used to check the correctness of rustc A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 28, 2024
@rustbot
Copy link
Collaborator

rustbot commented Oct 28, 2024

Some changes occurred in src/tools/compiletest

cc @jieyouxu

This PR modifies tests/run-make/. If this PR is trying to port a Makefile
run-make test to use rmake.rs, please update the
run-make port tracking issue
so we can track our progress. You can either modify the tracking issue
directly, or you can comment on the tracking issue and link this PR.

cc @jieyouxu

rustc_macros::diagnostics was changed

cc @davidtwco, @compiler-errors, @TaKO8Ki

jyn514 and others added 4 commits October 27, 2024 21:23
@jyn514
remove dead code in CGREP script
d792e1f
@jyn514
give a better error for tuple structs in derive(Diagnostic)
3141a65
@jyn514
port tests/ui/linkage-attr/framework to run-make
f1e5b36 
this makes it much easier to understand test failures.

before:
```
diff of stderr:

1 error: linking with `LINKER` failed: exit status: 1
2    |
-            ld: Undefined symbols:
4              _CFRunLoopGetTypeID, referenced from:
5            clang: error: linker command failed with exit code 1 (use -v to see invocation)
```

after:
```
=== HAYSTACK ===
error: linking with `cc` failed: exit status: 1
  |
  = note: use `--verbose` to show all linker arguments
  = note: Undefined symbols for architecture arm64:
            "_CFRunLoopGetTypeID", referenced from:
                main::main::hbb553f5dda62d3ea in main.main.d17f5fbe6225cf88-cgu.0.rcgu.o
          ld: symbol(s) not found for architecture arm64
          clang: error: linker command failed with exit code 1 (use -v to see invocation)

error: aborting due to 1 previous error

=== NEEDLE ===
_CFRunLoopGetTypeID\.?, referenced from:
thread 'main' panicked at /Users/jyn/git/rust-lang/rust/tests/run-make/linkage-attr-framework/rmake.rs:22:10:
needle was not found in haystack
```

this also fixes a failure related to missing whitespace; we don't actually care about whitespace in this test.
@jyn514
don't pass -L .../auxiliary unless it exists
675f447 
this avoids warnings from macOS ld
@bjorn3
Copy link
Member

bjorn3 commented Oct 28, 2024

@bors r+

@bors
Copy link
Contributor

bors commented Oct 28, 2024

📌 Commit 675f447 has been approved by bjorn3

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 28, 2024
@bors
Copy link
Contributor

bors commented Oct 28, 2024

⌛ Testing commit 675f447 with merge 32b17d5...

@bors
Copy link
Contributor

bors commented Oct 28, 2024

☀️ Test successful - checks-actions
Approved by: bjorn3
Pushing 32b17d5 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Oct 28, 2024
@bors bors merged commit 32b17d5 into rust-lang:master Oct 28, 2024
7 checks passed
@rustbot rustbot added this to the 1.84.0 milestone Oct 28, 2024
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (32b17d5): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 783.609s -> 784.348s (0.09%)
Artifact size: 333.69 MiB -> 333.70 MiB (0.00%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@bjorn3 bjorn3

Labels
A-compiletest Area: The compiletest test runner A-run-make Area: port run-make Makefiles to rmake.rs A-testsuite Area: The testsuite used to check the correctness of rustc A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.84.0
Development

Successfully merging this pull request may close these issues.
5 participants
@jyn514 @rustbot @bjorn3 @bors @rust-timer