Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix various linker warnings #132244

Merged
merged 4 commits into from
Oct 28, 2024
Merged

fix various linker warnings #132244

merged 4 commits into from
Oct 28, 2024

Commits on Oct 28, 2024

  1. remove dead code in CGREP script

    @jyn514
    jyn514 committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    d792e1f View commit details
    Browse the repository at this point in the history

  2. give a better error for tuple structs in derive(Diagnostic)

    @jyn514
    jyn514 committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    3141a65 View commit details
    Browse the repository at this point in the history

  3. port tests/ui/linkage-attr/framework to run-make 

    this makes it much easier to understand test failures.

before:
```
diff of stderr:

1 error: linking with `LINKER` failed: exit status: 1
2    |
-            ld: Undefined symbols:
4              _CFRunLoopGetTypeID, referenced from:
5            clang: error: linker command failed with exit code 1 (use -v to see invocation)
```

after:
```
=== HAYSTACK ===
error: linking with `cc` failed: exit status: 1
  |
  = note: use `--verbose` to show all linker arguments
  = note: Undefined symbols for architecture arm64:
            "_CFRunLoopGetTypeID", referenced from:
                main::main::hbb553f5dda62d3ea in main.main.d17f5fbe6225cf88-cgu.0.rcgu.o
          ld: symbol(s) not found for architecture arm64
          clang: error: linker command failed with exit code 1 (use -v to see invocation)

error: aborting due to 1 previous error

=== NEEDLE ===
_CFRunLoopGetTypeID\.?, referenced from:
thread 'main' panicked at /Users/jyn/git/rust-lang/rust/tests/run-make/linkage-attr-framework/rmake.rs:22:10:
needle was not found in haystack
```

this also fixes a failure related to missing whitespace; we don't actually care about whitespace in this test.
    @jyn514
    jyn514 committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    f1e5b36 View commit details
    Browse the repository at this point in the history

  4. don't pass -L .../auxiliary unless it exists 

    this avoids warnings from macOS ld
    @jyn514
    jyn authored and jyn514 committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    675f447 View commit details
    Browse the repository at this point in the history