Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: switch dist-x86_64-musl to free runner #132411

Merged
merged 1 commit into from
Nov 2, 2024

Conversation

MarcoIeni
Copy link
Member

@MarcoIeni MarcoIeni commented Oct 31, 2024

Similar to #132396 and #132316

I noticed that some jobs running on large runners are significantly faster than the rest of the auto build.

Here's some data based on the latest 97 auto builds:

  • Average of these jobs:
    • dist-x86_64-musl: 77 minutes
    • i686-gnu: 102 minutes (EDIT: this takes too long)
  • Minimum duration of the auto builds: 136 minutes (2h 16 min).
  • Average duration of the auto build: 155 minutes (2h 35 min).

try-job: dist-x86_64-musl

@rustbot
Copy link
Collaborator

rustbot commented Oct 31, 2024

r? @Kobzol

rustbot has assigned @Kobzol.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Oct 31, 2024
@MarcoIeni
Copy link
Member Author

@bors try

@bors
Copy link
Contributor

bors commented Oct 31, 2024

⌛ Trying commit 0c48532 with merge 27907eb...

bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 31, 2024
… r=<try>

CI: switch dist-x86_64-musl and i686-gnu to free runners

try-job: dist-x86_64-musl
try-job: i686-gnu
@bors
Copy link
Contributor

bors commented Oct 31, 2024

☀️ Try build successful - checks-actions
Build commit: 27907eb (27907eb9e2c5ba6c9594020d3b0755e1f86ca2de)

@MarcoIeni
Copy link
Member Author

i686-gnu takes definitely too long, while dist-x86_64-musl looks reasonable.
I will force-push to undo the i686-gnu change and test dist-x86_64-musl again, just to be sure that it doesn't take too long.

image

@MarcoIeni MarcoIeni force-pushed the ci-switch-to-free-runners branch from 0c48532 to d39270f Compare November 1, 2024 20:11
@MarcoIeni
Copy link
Member Author

@bors try

@MarcoIeni MarcoIeni changed the title CI: switch dist-x86_64-musl and i686-gnu to free runners CI: switch dist-x86_64-musl to free runner Nov 1, 2024
@bors
Copy link
Contributor

bors commented Nov 1, 2024

⌛ Trying commit d39270f with merge 1586613...

bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 1, 2024
… r=<try>

CI: switch dist-x86_64-musl to free runner

try-job: dist-x86_64-musl
@bors
Copy link
Contributor

bors commented Nov 1, 2024

☀️ Try build successful - checks-actions
Build commit: 1586613 (15866139de2220ddafbe21716b5ed92f96fc43da)

@MarcoIeni
Copy link
Member Author

looks good, I think this can be merged 👍
image

@MarcoIeni MarcoIeni marked this pull request as ready for review November 1, 2024 23:29
@Kobzol
Copy link
Contributor

Kobzol commented Nov 2, 2024

@bors r+

@bors
Copy link
Contributor

bors commented Nov 2, 2024

📌 Commit d39270f has been approved by Kobzol

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 2, 2024
workingjubilee added a commit to workingjubilee/rustc that referenced this pull request Nov 2, 2024
…s, r=Kobzol

CI: switch dist-x86_64-musl to free runner

try-job: dist-x86_64-musl
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 2, 2024
…iaskrgr

Rollup of 11 pull requests

Successful merges:

 - rust-lang#131037 (Move versioned Apple LLVM targets from `rustc_target` to `rustc_codegen_ssa`)
 - rust-lang#132170 (Add a Few Codegen Tests)
 - rust-lang#132333 (rust_analyzer_helix.toml: add library/ manifest)
 - rust-lang#132398 (Add a couple of intra-doc links to str)
 - rust-lang#132411 (CI: switch dist-x86_64-musl to free runner)
 - rust-lang#132453 (Also treat `impl` definition parent as transparent regarding modules)
 - rust-lang#132457 (Remove needless #![feature(asm_experimental_arch)] from loongarch64 inline assembly test)
 - rust-lang#132465 (refactor(config): remove FIXME statement in comment of `omit-git-hash`)
 - rust-lang#132466 (Account for late-bound depth when capturing all opaque lifetimes.)
 - rust-lang#132471 (Add a bunch of mailmap entries)
 - rust-lang#132488 (Remove or fix some more `FIXME(async_closure)`)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit e5269bb into rust-lang:master Nov 2, 2024
7 checks passed
@rustbot rustbot added this to the 1.84.0 milestone Nov 2, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Nov 2, 2024
Rollup merge of rust-lang#132411 - MarcoIeni:ci-switch-to-free-runners, r=Kobzol

CI: switch dist-x86_64-musl to free runner

try-job: dist-x86_64-musl
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants