Account for late-bound depth when capturing all opaque lifetimes. #132466

cjgillot · 2024-11-01T17:46:56Z

compiler-errors · 2024-11-01T17:51:56Z

Can you please add this as a check-pass test:

use std::future::Future;

trait Test {
    fn foo<'a>(&'a self) -> Box<dyn Future<Output = impl IntoIterator<Item = u32>>> {
        Box::new(async { [] })
    }
}

fn main() {}

compiler-errors · 2024-11-01T17:52:39Z

Actually, just delete that other test. That one is not as minimized as the one I shared above, which also reproduces this ICE but doesn't result in an unnecessary type error.

compiler-errors · 2024-11-02T04:50:35Z

@bors r+

bors · 2024-11-02T04:50:38Z

📌 Commit e2a50de has been approved by compiler-errors

It is now in the queue for this repository.

…rrors Account for late-bound depth when capturing all opaque lifetimes. Fixes rust-lang#132429 r? `@compiler-errors`

…rrors Account for late-bound depth when capturing all opaque lifetimes. Fixes rust-lang#132429 r? ``@compiler-errors``

…rrors Account for late-bound depth when capturing all opaque lifetimes. Fixes rust-lang#132429 r? ```@compiler-errors```

…iaskrgr Rollup of 11 pull requests Successful merges: - rust-lang#131037 (Move versioned Apple LLVM targets from `rustc_target` to `rustc_codegen_ssa`) - rust-lang#132170 (Add a Few Codegen Tests) - rust-lang#132333 (rust_analyzer_helix.toml: add library/ manifest) - rust-lang#132398 (Add a couple of intra-doc links to str) - rust-lang#132411 (CI: switch dist-x86_64-musl to free runner) - rust-lang#132453 (Also treat `impl` definition parent as transparent regarding modules) - rust-lang#132457 (Remove needless #![feature(asm_experimental_arch)] from loongarch64 inline assembly test) - rust-lang#132465 (refactor(config): remove FIXME statement in comment of `omit-git-hash`) - rust-lang#132466 (Account for late-bound depth when capturing all opaque lifetimes.) - rust-lang#132471 (Add a bunch of mailmap entries) - rust-lang#132488 (Remove or fix some more `FIXME(async_closure)`) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#132466 - cjgillot:opaque-late, r=compiler-errors Account for late-bound depth when capturing all opaque lifetimes. Fixes rust-lang#132429 r? ````@compiler-errors````

…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#131037 (Move versioned Apple LLVM targets from `rustc_target` to `rustc_codegen_ssa`) - rust-lang#132398 (Add a couple of intra-doc links to str) - rust-lang#132453 (Also treat `impl` definition parent as transparent regarding modules) - rust-lang#132457 (Remove needless #![feature(asm_experimental_arch)] from loongarch64 inline assembly test) - rust-lang#132465 (refactor(config): remove FIXME statement in comment of `omit-git-hash`) - rust-lang#132466 (Account for late-bound depth when capturing all opaque lifetimes.) - rust-lang#132471 (Add a bunch of mailmap entries) - rust-lang#132488 (Remove or fix some more `FIXME(async_closure)`) r? `@ghost` `@rustbot` modify labels: rollup

Deny capturing late-bound ty/const params in nested opaques First, this reverts a7f6095. I can't exactly remember why I approved this specific bit of rust-lang#132466; specifically, I don't know that the purpose of that commit is, and afaict we will never have an opaque that captures late-bound params through a const because opaques can't be used inside of anon consts. Am I missing something `@cjgillot?` Since I can't see a case where this matters, and no tests seem to fail. The second commit adds a `deny_late_regions: bool` to distinguish `Scope::LateBoundary` which should deny *any* late-bound params or just ty/consts. Then, when resolving opaques we wrap ourselves in a `Scope::LateBoundary { deny_late_regions: false }` so that we deny late-bound ty/const, which fixes a bunch of ICEs that all vaguely look like `impl for<T> Trait<Assoc = impl OtherTrait<T>>`. I guess this could be achieved other ways; for example, with a different scope kind, or maybe we could just reuse `Scope::Opaque`. But this seems a bit more verbose. I'm open to feedback anyways. Fixes rust-lang#131535 Fixes rust-lang#131637 Fixes rust-lang#132530 I opted to remove those crashes tests ^ without adding them as regular tests, since they're basically triggering uninteresting late-bound ICEs far off in the trait solver, and the reason that existing tests such as `tests/ui/type-alias-impl-trait/non-lifetime-binder-in-constraint.rs` don't ICE are kinda just coincidental (i.e. due to a missing impl block). I don't really feel motivated to add random permutations to tests just to exercise non-lifetime binders. r? cjgillot

Rollup merge of rust-lang#132832 - compiler-errors:late-ty, r=cjgillot Deny capturing late-bound ty/const params in nested opaques First, this reverts a7f6095. I can't exactly remember why I approved this specific bit of rust-lang#132466; specifically, I don't know that the purpose of that commit is, and afaict we will never have an opaque that captures late-bound params through a const because opaques can't be used inside of anon consts. Am I missing something `@cjgillot?` Since I can't see a case where this matters, and no tests seem to fail. The second commit adds a `deny_late_regions: bool` to distinguish `Scope::LateBoundary` which should deny *any* late-bound params or just ty/consts. Then, when resolving opaques we wrap ourselves in a `Scope::LateBoundary { deny_late_regions: false }` so that we deny late-bound ty/const, which fixes a bunch of ICEs that all vaguely look like `impl for<T> Trait<Assoc = impl OtherTrait<T>>`. I guess this could be achieved other ways; for example, with a different scope kind, or maybe we could just reuse `Scope::Opaque`. But this seems a bit more verbose. I'm open to feedback anyways. Fixes rust-lang#131535 Fixes rust-lang#131637 Fixes rust-lang#132530 I opted to remove those crashes tests ^ without adding them as regular tests, since they're basically triggering uninteresting late-bound ICEs far off in the trait solver, and the reason that existing tests such as `tests/ui/type-alias-impl-trait/non-lifetime-binder-in-constraint.rs` don't ICE are kinda just coincidental (i.e. due to a missing impl block). I don't really feel motivated to add random permutations to tests just to exercise non-lifetime binders. r? cjgillot

cjgillot added 2 commits November 1, 2024 17:03

Account for late-bound depth when capturing all opaque lifetimes.

45d4465

Skip late-bound lifetimes when crossing an AnonConst.

a7f6095

rustbot assigned compiler-errors Nov 1, 2024

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 1, 2024

This comment has been minimized.

Sign in to view

Use more minimized test.

e2a50de

cjgillot force-pushed the opaque-late branch from 4e4beb7 to e2a50de Compare November 1, 2024 18:13

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 2, 2024

workingjubilee mentioned this pull request Nov 2, 2024

Rollup of 7 pull requests #132490

Closed

matthiaskrgr mentioned this pull request Nov 2, 2024

Rollup of 8 pull requests #132491

Closed

workingjubilee mentioned this pull request Nov 2, 2024

Rollup of 10 pull requests #132496

Closed

matthiaskrgr mentioned this pull request Nov 2, 2024

Rollup of 11 pull requests #132497

Merged

bors merged commit 020b63a into rust-lang:master Nov 2, 2024
6 checks passed

rustbot added this to the 1.84.0 milestone Nov 2, 2024

cjgillot mentioned this pull request Nov 2, 2024

ICE: impl_trait_in_fn_trait_return index out of bounds #132518

Closed

cjgillot deleted the opaque-late branch November 2, 2024 13:36

compiler-errors mentioned this pull request Nov 10, 2024

Deny capturing late-bound ty/const params in nested opaques #132832

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Account for late-bound depth when capturing all opaque lifetimes. #132466

Account for late-bound depth when capturing all opaque lifetimes. #132466

cjgillot commented Nov 1, 2024

compiler-errors commented Nov 1, 2024

compiler-errors commented Nov 1, 2024

This comment has been minimized.

compiler-errors commented Nov 2, 2024

bors commented Nov 2, 2024

Account for late-bound depth when capturing all opaque lifetimes. #132466

Account for late-bound depth when capturing all opaque lifetimes. #132466

Conversation

cjgillot commented Nov 1, 2024

compiler-errors commented Nov 1, 2024

compiler-errors commented Nov 1, 2024

This comment has been minimized.

compiler-errors commented Nov 2, 2024

bors commented Nov 2, 2024