Struct undef repr #16499
Merged
Struct undef repr #16499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if variants.len() != 0 { | ||
| let repr_hints = lookup_repr_hints(cx, did); | ||
| if repr_hints.len() > 1 { | ||
| // this is an error later on, but this type isn't safe |
There was a problem hiding this comment.
Does this actually need special handling?
There was a problem hiding this comment.
Possibly. Anything that queries type_contents for this but doesn't actually run trans is going to run up against this, I believe. (The error is in adt, iirc)
bors
added a commit
that referenced
this pull request
Aug 16, 2014
As of RFC 18, struct layout is undefined. Opting into a C-compatible struct layout is now down with #[repr(C)]. For consistency, specifying a packed layout is now also down with #[repr(packed)]. Both can be specified. To fix errors caused by this, just add #[repr(C)] to the structs, and change #[packed] to #[repr(packed)] Closes #14309 [breaking-change]
int/uint aren't considered FFI safe, replace them with the actual type they represent (i64/u64 or i32/u32). This is a breaking change, but at most a cast to `uint` or `int` needs to be added. [breaking-change]
bors
added a commit
that referenced
this pull request
Aug 21, 2014
klutzy
added a commit
to klutzy/rust
that referenced
this pull request
May 17, 2015
The attribute was removed by rust-lang#16499.
bors
added a commit
that referenced
this pull request
May 18, 2015
The attribute was removed by #16499.
matthiaskrgr
pushed a commit
to matthiaskrgr/rust
that referenced
this pull request
Feb 11, 2024
internal: Update rustc_pattern_analysis dependency Just bumping the dependency, as I've been making API changes over on the rustc side. More API changes incoming in the coming weeks. One benefit of this: we no longer abort in the `DeconstructedPat: Debug` impl, which means we can use `tracing` to investigate issues.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @pcwalton