Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

syntax: Remove unused packed attribute #25541

Merged
merged 1 commit into from
May 18, 2015
Merged

syntax: Remove unused packed attribute #25541

merged 1 commit into from
May 18, 2015

Conversation

klutzy
Copy link
Contributor

@klutzy klutzy commented May 17, 2015

The attribute was removed by #16499.

@rust-highfive
Copy link
Collaborator

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@alexcrichton
Copy link
Member

Hm, so technically this is a breaking change as any existing #[packed] attributes will start to be an error instead of being silently ignored, but I believe that this falls under the "easy fix" purview of rust-lang/rfcs#1105, so I think that this is fine to go through.

@bors: r+ d0fc35f

@klutzy
Copy link
Contributor Author

klutzy commented May 18, 2015

Yep, I think this is the case of "Minor change: introducing new lint warnings/errors" of the RFC. This patch was made since a Rust beginner misused #[packed] but compiler didn't make a warning.

@bors
Copy link
Contributor

bors commented May 18, 2015

⌛ Testing commit d0fc35f with merge 8a8583c...

bors added a commit that referenced this pull request May 18, 2015
@bors
Auto merge of #25541 - klutzy:remove-packed-attr, r=alexcrichton
8a8583c 
The attribute was removed by #16499.
@bors
Copy link
Contributor

bors commented May 18, 2015

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-x-android-t, auto-mac-32-opt, auto-mac-64-nopt-t, auto-mac-64-opt, auto-win-32-nopt-t, auto-win-32-opt, auto-win-64-nopt-t, auto-win-64-opt

@bors bors merged commit d0fc35f into rust-lang:master May 18, 2015
@klutzy klutzy deleted the remove-packed-attr branch May 18, 2015 03:25
@liamsi liamsi mentioned this pull request Jun 13, 2015
Closed
liamsi added a commit to liamsi/qmlrs that referenced this pull request Jun 13, 2015
@liamsi
packed attribute was removed (rust-lang/rust#25541)
94c51aa
@liamsi liamsi mentioned this pull request Jun 13, 2015
Merged
@brson brson added regression-from-stable-to-nightly Performance or correctness regression from stable to nightly. relnotes Marks issues that should be documented in the release notes of the next release. labels Jul 13, 2015
@brson
Copy link
Contributor

brson commented Jul 13, 2015

As mentioned here this causes stable regressions with crates that were using the #[packed] attribute.

steveklabnik added a commit to steveklabnik/libnetfilter_queue that referenced this pull request Jul 21, 2015
@steveklabnik
Remove unused packed attribute
12d2b84 
See rust-lang/rust#25541
AnIrishDuck added a commit to AnIrishDuck/rusty-prism that referenced this pull request Nov 13, 2015
@AnIrishDuck
Deprecated, see rust-lang/rust#25541
8b98830
fsck pushed a commit to fsck/libnetfilter_queue that referenced this pull request Oct 11, 2016
@steveklabnik @fsck
Remove unused packed attribute
9826169 
See rust-lang/rust#25541
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@alexcrichton alexcrichton

Labels
regression-from-stable-to-nightly Performance or correctness regression from stable to nightly. relnotes Marks issues that should be documented in the release notes of the next release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@klutzy @rust-highfive @alexcrichton @bors @brson