Correct parsing of the precedence of +
#19298
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikomatsakis
force-pushed
the
unboxed-closure-parse-the-plus
branch
from
8431117 to
d9cc7c4
Compare
nikomatsakis
force-pushed
the
unboxed-closure-parse-the-plus
branch
from
d9cc7c4 to
77668ea
Compare
8 tasks
nikomatsakis
force-pushed
the
unboxed-closure-parse-the-plus
branch
2 times, most recently
from
21d5d13 to
19507fd
Compare
…e AST appropriately.
nikomatsakis
force-pushed
the
unboxed-closure-parse-the-plus
branch
from
19507fd to
b219bd5
Compare
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this pull request
Nov 27, 2014
…he-plus Implements RFC 438. Fixes rust-lang#19092. This is a [breaking-change]: change types like `&Foo+Send` or `&'a mut Foo+'a` to `&(Foo+Send)` and `&'a mut (Foo+'a)`, respectively. r? @brson
|
Rolled into #19298 |
|
Er sorry, #19342 |
TeXitoi
added a commit
to TeXitoi/rust-protobuf
that referenced
this pull request
Nov 27, 2014
stepancheg
pushed a commit
to stepancheg/rust-protobuf
that referenced
this pull request
Nov 28, 2014
bors
added a commit
that referenced
this pull request
Mar 22, 2017
Refactor parsing of trait object types Bugs are fixed and code is cleaned up. User visible changes: - `ty` matcher in macros accepts trait object types like `Write + Send` (#39080) - Buggy priority of `+` in trait object types starting with `for` is fixed (#39317). `&for<'a> Trait<'a> + Send` is now parsed as `(&for<'a> Trait<'a>) + Send` and requires parens `&(for<'a> Trait<'a> + Send)`. For comparison, `&Send + for<'a> Trait<'a>` was parsed like this since [Nov 27, 2014](#19298). - Trailing `+`s are supported in trait objects, like in other bounds. - Better error reporting for trait objects starting with `?Sized`. Fixes #39080 Fixes #39317 [breaking-change] Closes #39298 cc #39085 (fixed, then reverted #40043 (comment)) cc #39318 (fixed, then reverted #40043 (comment)) r? @nikomatsakis
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements RFC 438.
Fixes #19092.
This is a [breaking-change]: change types like
&Foo+Sendor&'a mut Foo+'ato&(Foo+Send)and&'a mut (Foo+'a), respectively.r? @brson