Utilize fewer reexports #19407
Merged
Utilize fewer reexports #19407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
frewsxcv
force-pushed
the
rm-reexports
branch
from
710d6ef to
6614476
Compare
|
Yay for Windows issues. Just fixed that last error. |
@sfackler Does this mean we should retry? |
bors
added a commit
that referenced
this pull request
Nov 30, 2014
In regards to: #19253 (comment) This commit: * Changes the #deriving code so that it generates code that utilizes fewer reexports (in particur Option::\*, Result::\*, and Ordering::\*), which is necessary to remove those reexports in the future * Changes other areas of the codebase so that fewer reexports are utilized
|
:( |
frewsxcv
referenced
this pull request
in frewsxcv/rust
Nov 30, 2014
In regards to: rust-lang#19253 (comment) This commit: * Changes the #deriving code so that it generates code that utilizes fewer reexports (in particur Option::* and Result::*), which is necessary to remove those reexports in the future * Changes other areas of the codebase so that fewer reexports are utilized
|
@frewsxcv that's been happening a lot on the buildbots lately and retrying sadly won't fix. It likely has to do with a DefId mismatch of using the wrong crate. For now a number of PRs are blocked on this issue and I think we'll have to fix it before landing this sadly. |
|
@alexcrichton Is there an open GitHub Issue I can follow related to that issue? |
frewsxcv
force-pushed
the
rm-reexports
branch
from
6614476 to
02fcd95
Compare
|
Can I get a retry for this now that 719c36c#diff-61bc16bb841787d2ec81342b2369db1bR18 happened? |
frewsxcv
force-pushed
the
rm-reexports
branch
from
02fcd95 to
b2ca72a
Compare
In regards to: rust-lang#19253 (comment) This commit: * Changes the #deriving code so that it generates code that utilizes fewer reexports (in particur Option::* and Result::*), which is necessary to remove those reexports in the future * Changes other areas of the codebase so that fewer reexports are utilized
frewsxcv
force-pushed
the
rm-reexports
branch
from
b2ca72a to
4ef1674
Compare
|
Rebased off master and fixed conflicts |
|
This will need a retry once the Android build stops failing everything |
|
Looks like the Android issue is fixed. May I get a retry? |
bors
added a commit
that referenced
this pull request
Dec 7, 2014
In regards to: #19253 (comment) This commit: * Changes the #deriving code so that it generates code that utilizes fewer reexports (in particur Option::\*, Result::\*, and Ordering::\*), which is necessary to remove those reexports in the future * Changes other areas of the codebase so that fewer reexports are utilized
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this pull request
Dec 9, 2014
Brief note: This does *not* affect anything in the prelude Part of rust-lang#19253 All this does is remove the reexporting of Result and Option from their respective modules. More core reexports might be removed, but these ones are the safest to remove since these enums (and their variants) are included in the prelude. Depends on rust-lang#19407 which is merged, but might need a new snapshot [breaking-change]
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this pull request
Dec 22, 2014
Part of rust-lang#19253 I would have removed this public reexport in rust-lang#19842, but rust-lang#19812 hadn't merged (and snapshotted) at the time In rust-lang#19407, I changed the codebase to stop utilizing this reexport [breaking-change]
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this pull request
Dec 22, 2014
Part of rust-lang#19253 I would have removed this public reexport in rust-lang#19842, but rust-lang#19812 hadn't merged (and snapshotted) at the time In rust-lang#19407, I changed the codebase to stop utilizing this reexport [breaking-change]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In regards to:
#19253 (comment)
This commit:
reexports (in particur Option::, Result::, and Ordering::*), which is necessary to
remove those reexports in the future