-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 21 pull requests #27219
Merged
Merged
Rollup of 21 pull requests #27219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
steveklabnik
commented
Jul 22, 2015
- Successful merges: Add E0403, E0404, E0405, E0407, E0428 and E0433 error explanation #27084, Add diagnostics for E0172, fix inline message for E0139 #27127, add test for #20162 #27131, Add a test for #26468 #27140, add test for #14229 #27146, add test for #19404 #27147, s/has gained/has not gained/g #27151, add test for #10436 #27154, Improve documentation for std::io::BufWriter #27155, Fix wording nit for E0253 #27156, Document iterators in std::io #27157, add test for #14382 #27158, Improve documentation for std::io::Cursor #27163, Document structures in std::io::utils #27164, Improve documentation for std::io::LineWriter #27166, Update docs for take and broadcast #27167, Expand documentation for IntoInnerError #27170, Add travis config to TRPL: release channels #27175, Guidance on Windows install re "Add to PATH" #27183, Trivial changes in the Rust book. #27201, update compile-fail test for #21174 to account for #27127 #27202
- Failed merges: Error message for E0307 is weird #26485 #26778
This commit fixes the negate_unsigned feature gate to appropriately account for infered variables. This is technically a [breaking-change].
and deprecate/remove unsigned_negation lint. This is useful to avoid causing breaking changes in case #![deny(unknown_lints)] is used and lint is removed.
The "hint" mechanism is essentially used as a workaround to compute types for expressions which have not yet been type-checked. This commit clarifies that usage, and limits the effects to the places where it is currently necessary. Fixes rust-lang#26210.
Some cases displayed negative impls as positive, and some were missing where clauses. This factors all the impl formatting into one function so the different cases can't get out of sync again.
We're currently using the actual function type as the return type when creating the debug info for a function, so we're actually creating debug info for a function that takes the same parameters, and returns the actual function type, which is completely wrong.
Internally, the arguments passed to the closure are represented by a tuple, but the actual function takes them as individual arguments, so we have to untuple the arguments before creating the debuginfo.
Instead of generating pointer debug info, we're currently generating subroutine debug info.
the "bsd" archive_format don't work under openbsd. use of "" (system ar) is ok. use of "gnu" is ok too.
in one invocation.
The fix for rust-lang#26468 was made upstream and landed with the LLVM update in rust-lang#27076. Closes rust-lang#26468
Variables for closures hold a tuple of captured variables, and not the function itself. Fixes rust-lang#26484
See the commits for details r? @arielb1
I'm pretty sure this was a typo
This commit is an implementation of [RFC 1174][rfc] which adds three new traits to the standard library: * `IntoRawFd` - implemented on Unix for all I/O types (files, sockets, etc) * `IntoRawHandle` - implemented on Windows for files, processes, etc * `IntoRawSocket` - implemented on Windows for networking types [rfc]: https://github.com/rust-lang/rfcs/blob/master/text/1174-into-raw-fd-socket-handle-traits.md Closes rust-lang#27062
This commit ensures that the rustc thread does not leak a panic message whenever a call to `fatal` happens. This already happens for the main rustc thread as part of the `rustc_driver::monitor` function, but the compiler also spawns threads for other operations like `-C codegen-units`, and sometimes errors are emitted on these threads as well. To ensure that there's a consistent error-handling experience across threads this unifies these two to never print the panic message in the case of a normal and expected fatal error. This should also fix the flaky `asm-src-loc-codegen-units.rs` test as the output is sometimes garbled if diagnostics are printed while the panic message is also being printed.
This commit fixes the negate_unsigned feature gate to appropriately account for inferred variables. This is technically a [breaking-change], but I’d consider it a bug fix. cc @brson for your relnotes. Fixes rust-lang#24676 Fixes rust-lang#26840 Fixes rust-lang#25206
These new snapshots contain the knowledge of how to build the new triples of 32-bit MSVC and 32-bit FreeBSD, both of which should soon start having nightlies/auto builders! This does not currently register bitrig/freebsd snapshots but I believe those will be retroactively added in the near future.
I'm pretty sure this was a typo
… r=alexcrichton Mostly through adding examples. r? @alexcrichton I'm going to be doing a bunch of these today, but I figured I'd keep it one PR per struct, since the last 'all the things in one PR' ended up taking a week to actually land.
…arth This is a resubmission of my previous git failure - apologies. Just fixing up a wording error that was discovered in E0253 after the r. r? @Manishearth
…r=alexcrichton Make them all consistent and link up the documentation. r? @alexcrichton
…lexcrichton Beef up the docs on the type, as well as adding examples for all methods. r? @alexcrichton
…ichton These provide various special readers, so point their docs to their constructor functions in a manner consistent with everything else. r? @alexcrichton
… r=alexcrichton Beef up the struct docs, add examples for the methods. r? @alexcrichton
…xcrichton Better and more consistent links to their creators.
…ror, r=alexcrichton Mostly adding examples. r? @alexcrichton
…r=alexcrichton This should help people configure travis to test all three channels.
Updated "Installing Rust" and "After installation" to provide additional guidance to Windows users on including Rust in the Path system variable. r? @steveklabnik
Just some small changes.
@bors: r+ force |
📌 Commit 5f04b1b has been approved by |
(rust_highfive has picked a reviewer for you, use r? to override) |
@bors: p=1000 |
@bors: force |
bors
added a commit
that referenced
this pull request
Jul 22, 2015
🎊 |
This was referenced Jul 22, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.