Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mistake in trait.md #28184

Merged
merged 1 commit into from
Sep 4, 2015
Merged

Fix mistake in trait.md #28184

merged 1 commit into from
Sep 4, 2015

Conversation

xiaochuanyu
Copy link
Contributor

Originally in an example it reads as follows:

fn inverse<T>() -> T
        // this is using ConvertTo as if it were "ConvertFrom<i32>"
         where i32: ConvertTo<T> {
     42.convert()
 }

There was no mention of ConvertFrom elsewhere in the page other than in this comment. Is this supposed to be ConvertTo<i64> ?
I'm confused by this example.

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@alexcrichton
Copy link
Member

@bors: r+ 865d6c3 rollup

Thanks!

Manishearth added a commit to Manishearth/rust that referenced this pull request Sep 3, 2015
Originally in an example it reads as follows:
```rust
fn inverse<T>() -> T
        // this is using ConvertTo as if it were "ConvertFrom<i32>"
         where i32: ConvertTo<T> {
     42.convert()
 }
```
There was no mention of `ConvertFrom` elsewhere in the page other than in this comment. Is this supposed to be `ConvertTo<i64>` ?
I'm confused by this example.
Manishearth added a commit to Manishearth/rust that referenced this pull request Sep 3, 2015
Originally in an example it reads as follows:
```rust
fn inverse<T>() -> T
        // this is using ConvertTo as if it were "ConvertFrom<i32>"
         where i32: ConvertTo<T> {
     42.convert()
 }
```
There was no mention of `ConvertFrom` elsewhere in the page other than in this comment. Is this supposed to be `ConvertTo<i64>` ?
I'm confused by this example.
bors added a commit that referenced this pull request Sep 3, 2015
@bors bors merged commit 865d6c3 into rust-lang:master Sep 4, 2015
@xiaochuanyu xiaochuanyu deleted the patch-1 branch September 4, 2015 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants