-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 10 pull requests #28200
Rollup of 10 pull requests #28200
Conversation
The embed rust file that we compile prints out 'Thread finished..' messages along with a 'done!'
this improves the compilation time for small crates by ~20%
…arth As title :-) Part of rust-lang#24407. r? @Manishearth
@bors r+ p=20 force |
📌 Commit 74bd544 has been approved by |
r? @huonw (rust_highfive has picked a reviewer for you, use r? to override) |
⌛ Testing commit 74bd544 with merge 7a57209... |
💔 Test failed - auto-linux-64-x-android-t |
@bors r+ force |
📌 Commit 34da3ce has been approved by |
⌛ Testing commit 34da3ce with merge b82149e... |
💔 Test failed - auto-linux-64-x-android-t |
@bors r+ force |
@bors force |
1 similar comment
@bors force |
@bors r+ p=20 force |
📌 Commit 00719c4 has been approved by |
@bors force |
⌛ Testing commit 00719c4 with merge 952641f... |
💔 Test failed - auto-linux-32-opt |
Originally in an example it reads as follows: ```rust fn inverse<T>() -> T // this is using ConvertTo as if it were "ConvertFrom<i32>" where i32: ConvertTo<T> { 42.convert() } ``` There was no mention of `ConvertFrom` elsewhere in the page other than in this comment. Is this supposed to be `ConvertTo<i64>` ? I'm confused by this example.
…st-inside-other-languages.md, r=steveklabnik The embed rust file that we compile prints out 'Thread finished..' messages along with a 'done!' r? @steveklabnik
And replace more `0 as *const T`/`0 as *mut T`s with `null()`/`null_mut()`s I'm not sure what is the general policy about making simple functions `const`, but `null()` and `null_mut()` seem to be good candidates.
Makes things more greppable. This change was made automatically by clippy + bash scripts, though I will run test passes, please review carefully.
Nothing too big, a few needless returns and a few closures eliminated (the latter may improve performance in some cases, at least compilation should be a bit faster).
…ests, r=alexcrichton @alexcrichton this will get the bitrig buildbot back to green.
…arth As title :-) Part of rust-lang#24407. r? @Manishearth
@bors r+ p=20 force |
📌 Commit e6e175b has been approved by |
💔 Test failed - auto-linux-32-opt |
@bors: retry force |
⚡ Previous build results for auto-linux-64-nopt-t, auto-linux-64-opt, auto-mac-32-opt, auto-mac-64-nopt-t, auto-mac-64-opt, auto-win-msvc-32-opt are reusable. Rebuilding only auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-x-android-t, auto-win-gnu-32-nopt-t, auto-win-gnu-32-opt, auto-win-gnu-64-nopt-t, auto-win-gnu-64-opt, auto-win-msvc-64-opt... |
null()
andnull_mut()
const functions #28187, Use lifetime elision in libcore #28188, clippy improvements to iterators #28191, Fixes #27886 -- bitrig does not use jemalloc (yet) #28193, Add an issue number to this FIXME #28194, add long diagnostics for E0214 #28195