Rollup of 9 pull requests #30929
Merged
Rollup of 9 pull requests #30929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Manishearth
commented
Jan 15, 2016
Manishearth
commented
- Successful merges: Instant/SystemTime doc: add meaning to first line #30591, Fixes #30628 by adding new snapshot for dragonfly bsd #30781, doc: Address issue of crates not being explained when introduced. #30836, resolve: Refactor away record_exports, fixing #4953 #30864, Preserve struct/variant kinds in metadata #30896, Require stability annotations on fields of tuple variants #30898, Update libbacktrace #30908, Do not ignore the test on MSVC #30921, update blksize_t in raw to reflect libc change under openbsd #30925
- Failed merges:
The first line (paragraph?) of a doc-comment is what rustdoc shows when listing items of a module. What makes `Instant` and `SystemTime` different is important enough to be there. (Though feel free to bikeshed the wording.)
… per aturon’s proposal.
This adds support for big endian and little endian PowerPC64. make check runs clean apart from one big endian backtrace issue.
Michael Ellerman pointed out that the system call for getrandom() on PowerPC Linux is incorrect. This bug was in the powerpc32 port, and was carried over to the powerpc64 port too.
While adding PowerPC64 support it was noticed that some testcases should just use target_pointer_width, and others should select between x86 and !x86.
* ref: Issue rust-lang#30825 Small punctuation change in "Crates and Modules".
|
@bors r+ p=100 |
|
📌 Commit 707d1b5 has been approved by |
|
⌛ Testing commit 707d1b5 with merge c166c3f... |
|
💔 Test failed - auto-win-gnu-64-opt |
The first line (paragraph?) of a doc-comment is what rustdoc shows when listing items of a module. What makes `Instant` and `SystemTime` different is important enough to be there. (Though feel free to bikeshed the wording.)
…lexcrichton This adds support for big endian and little endian PowerPC64. make check runs clean apart from one big endian backtrace issue.
…391630, r=alexcrichton @alexcrichton please upload the following snapshots: https://github.com/dhuseby/rust-manual-snapshots/raw/master/rust-stage0-2015-12-18-3391630-dragonfly-x86_64-e74d79488e88ac2de3bd03afd5959d2ae6e2b628.tar.bz2 thanks!
…nt, r=brson
There is now more structure to the report, so that you can specify e.g. an RFC/PR/issue number and other explanatory details.
Example message:
```
type-parameter-invalid-lint.rs:14:8: 14:9 error: defaults for type parameters are only allowed on type definitions, like `struct` or `enum`
type-parameter-invalid-lint.rs:14 fn avg<T=i32>(_: T) {}
^
type-parameter-invalid-lint.rs:14:8: 14:9 warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
type-parameter-invalid-lint.rs:14:8: 14:9 note: for more information, see PR 30742 <rust-lang#30724>
type-parameter-invalid-lint.rs:11:9: 11:28 note: lint level defined here
type-parameter-invalid-lint.rs:11 #![deny(future_incompatible)]
^~~~~~~~~~~~~~~~~~~
error: aborting due to previous error
```
r? @brson
I would really like feedback also on the specific messages!
Fixes rust-lang#30746
Ref issue [30825](rust-lang#30825) This commit should suffice to add a concise introduction to the concept of crates. My only worry, is that it is maybe too concise; but, the book seems to be written with the understanding that the new Rust user is coming from another language, and so will understand what a Library or Code Package is.
make `os::raw::tests::unix` test to pass again r? @alexcrichton
|
@bors r+ p=100 force |
|
📌 Commit 4f8d584 has been approved by |
bors
added a commit
that referenced
this pull request
Jan 15, 2016
This was referenced Jan 15, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.