resolve: fix the visibility of extern crates #31362

jseyfried · 2016-02-02T07:50:13Z

This PR changes the visibility of extern crate declarations to match that of items (fixes #26775).
To avoid breakage, the PR makes it a public_in_private lint to reexport a private extern crate, and it adds the lint inaccessible_extern_crate for uses of an inaccessible extern crate.

The lints can be avoided by making the appropriate extern crate declaration public.

jseyfried · 2016-02-02T08:56:46Z

cc @nikomatsakis @petrochenkov

petrochenkov · 2016-02-02T09:07:24Z

except that it allows private extern crate declarations to be re-exported. This exception considerably reduces breakage

It doesn't necessarily have to be a hard error immediately, you can mark such reexports with private_in_public warning (see https://github.com/rust-lang/rust/blob/master/src/librustc_resolve/resolve_imports.rs#L504 for example).
It's not like this warning is going to become an error any time soon.

jseyfried · 2016-02-02T11:38:48Z

@petrochenkov Good point, I added another commit making it a warning.

nrc · 2016-02-03T05:38:16Z

cc @rust-lang/lang

nrc · 2016-02-03T06:05:47Z

src/librustc_resolve/resolve_imports.rs

+                    if name_binding.is_extern_crate() {
+                        let msg = format!("extern crate `{}` is private, and cannot be reexported \
+                                           (error E0364), consider declaring with `pub`",
+                                           source);


can you move the consider... bit to a note please

oh wait, you can't it's a lint, nvm

nrc · 2016-02-03T06:08:58Z

The PR lgtm. I'll wait for a crater run and for the lang team to see this before giving r+ though.

aturon · 2016-02-03T15:47:16Z

Seems to match our previous decision on this question, so LGTM as well.

petrochenkov · 2016-02-03T18:28:00Z

src/librustc/lib.rs

@@ -68,6 +68,7 @@ extern crate serialize as rustc_serialize; // used by deriving
 #[cfg(test)]
 extern crate test;

+#[allow(private_in_public)]


Is pub extern crate very buggy? I think it can be used here instead of suppressing the warning. It will report the "pub extern crate does not work as expected" warning during stage0, but that's ok.

Good point, for some reason I thought that the warnings weren't ok.
pub extern crate works fine except that it is not visible to other crates (before this PR).

bors · 2016-02-05T08:54:48Z

☔ The latest upstream changes (presumably #31386) made this pull request unmergeable. Please resolve the merge conflicts.

jseyfried · 2016-02-06T08:48:11Z

This also closes #22146.

bors · 2016-02-11T06:50:03Z

☔ The latest upstream changes (presumably #31461) made this pull request unmergeable. Please resolve the merge conflicts.

bors · 2016-02-11T14:53:20Z

☔ The latest upstream changes (presumably #31487) made this pull request unmergeable. Please resolve the merge conflicts.

nrc · 2016-02-11T22:37:26Z

@brson or @alexcrichton could we get a crater run for this PR please?

bors · 2016-02-25T06:09:42Z

⌛ Testing commit 7ad7065 with merge f06ff1a...

…ty, r=nikomatsakis This PR changes the visibility of extern crate declarations to match that of items (fixes rust-lang#26775). To avoid breakage, the PR makes it a `public_in_private` lint to reexport a private extern crate, and it adds the lint `inaccessible_extern_crate` for uses of an inaccessible extern crate. The lints can be avoided by making the appropriate `extern crate` declaration public.

bors · 2016-02-25T07:00:57Z

⌛ Testing commit 7ad7065 with merge 4a01bac...

bors · 2016-02-25T08:28:15Z

💔 Test failed - auto-linux-64-nopt-t

- Successful merges: #31362, #31793, #31800, #31809, #31818, #31827, #31831, #31835, #31837, #31846 - Failed merges:

alexcrichton · 2016-02-25T17:09:40Z

@bors: retry

On Thu, Feb 25, 2016 at 12:28 AM, bors notifications@github.com wrote:

[image: 💔] Test failed - auto-linux-64-nopt-t
http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-t/builds/8166

—
Reply to this email directly or view it on GitHub
#31362 (comment).

rust-highfive assigned nrc Feb 2, 2016

jseyfried force-pushed the fix_extern_crate_visibility branch from eb4e401 to 794df1d Compare February 2, 2016 08:50

jseyfried force-pushed the fix_extern_crate_visibility branch 2 times, most recently from 9d5ef32 to 9f6dd8e Compare February 2, 2016 11:18

jseyfried force-pushed the fix_extern_crate_visibility branch 6 times, most recently from cce80e7 to 2168764 Compare February 3, 2016 00:34

nrc added the S-waiting-on-crater Status: Waiting on a crater run to be completed. label Feb 3, 2016

nrc reviewed Feb 3, 2016
View reviewed changes

petrochenkov reviewed Feb 3, 2016
View reviewed changes

jseyfried force-pushed the fix_extern_crate_visibility branch from 73e8496 to f722e31 Compare February 5, 2016 09:23

jseyfried force-pushed the fix_extern_crate_visibility branch from f722e31 to 44d605c Compare February 6, 2016 09:06

jseyfried mentioned this pull request Feb 11, 2016

Fix regression in resolve #31566

Merged

jseyfried force-pushed the fix_extern_crate_visibility branch 2 times, most recently from ea0b0d5 to 3acbd2f Compare February 11, 2016 08:05

Manishearth mentioned this pull request Feb 25, 2016

Rollup of 10 pull requests #31882

Merged

Manishearth closed this Feb 25, 2016

Manishearth reopened this Feb 25, 2016

bors added a commit that referenced this pull request Feb 25, 2016

Auto merge of #31882 - Manishearth:rollup, r=Manishearth

c9852e2

- Successful merges: #31362, #31793, #31800, #31809, #31818, #31827, #31831, #31835, #31837, #31846 - Failed merges:

bors merged commit 7ad7065 into rust-lang:master Feb 25, 2016

llogiq mentioned this pull request Feb 28, 2016

TWIR 120's CotW + PRs rust-lang/this-week-in-rust#174

Closed

SimonSapin mentioned this pull request Mar 5, 2016

rustdoc: Split out rustdoc pass to strip private imports #32055

Merged

jseyfried mentioned this pull request Mar 15, 2016

[WIP] Implement RFC 1560. #32213

Closed

jseyfried mentioned this pull request Mar 23, 2016

Glob imports ignore extern crate items of parent modules #22146

Closed

jseyfried deleted the fix_extern_crate_visibility branch March 25, 2016 22:53

bvssvni mentioned this pull request Apr 6, 2016

Disable CI for repos that break on stable PistonDevelopers/piston#1050

Closed

5 tasks

jseyfried mentioned this pull request Apr 10, 2016

Changes to name resolution rust-lang/rfcs#1560

Merged

mitchmindtree mentioned this pull request Apr 17, 2016

examples don't compile - Could not compile piston_window. PistonDevelopers/conrod#713

Closed

jgilchrist mentioned this pull request Apr 18, 2016

Explicitly re-export tcod_sys (ffi) tomassedovic/tcod-rs#219

Merged

petrochenkov mentioned this pull request Jun 28, 2016

Tracking issue for private_in_public compatibility lint. #34537

Closed

5 tasks

Moredread mentioned this pull request Sep 26, 2016

ICE when documenting crate that triggers PR 31362 warning #36747

Closed

petrochenkov mentioned this pull request Oct 1, 2016

Tracking issue for inaccessible_extern_crate compatibility lint #36886

Closed

3 tasks

jseyfried mentioned this pull request Oct 7, 2016

Fix importing inaccessible extern crates (with a warning) #37023

Merged

jseyfried changed the title ~~Resolve: Fix the visibility of extern crates~~ resolve: Fix the visibility of extern crates Feb 14, 2017

jseyfried changed the title ~~resolve: Fix the visibility of extern crates~~ resolve: fix the visibility of extern crates Feb 14, 2017

SimonSapin mentioned this pull request Oct 30, 2017

Add bindings to all jemalloc public functions gnzlbg/jemallocator#21

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

resolve: fix the visibility of extern crates #31362

resolve: fix the visibility of extern crates #31362

jseyfried commented Feb 2, 2016

jseyfried commented Feb 2, 2016

petrochenkov commented Feb 2, 2016

jseyfried commented Feb 2, 2016

nrc commented Feb 3, 2016

nrc Feb 3, 2016

nrc Feb 3, 2016

nrc commented Feb 3, 2016

aturon commented Feb 3, 2016

petrochenkov Feb 3, 2016

jseyfried Feb 4, 2016

bors commented Feb 5, 2016

jseyfried commented Feb 6, 2016

bors commented Feb 11, 2016

bors commented Feb 11, 2016

nrc commented Feb 11, 2016

bors commented Feb 25, 2016

bors commented Feb 25, 2016

bors commented Feb 25, 2016

alexcrichton commented Feb 25, 2016

resolve: fix the visibility of extern crates #31362

resolve: fix the visibility of extern crates #31362

Conversation

jseyfried commented Feb 2, 2016

jseyfried commented Feb 2, 2016

petrochenkov commented Feb 2, 2016

jseyfried commented Feb 2, 2016

nrc commented Feb 3, 2016

nrc Feb 3, 2016

Choose a reason for hiding this comment

nrc Feb 3, 2016

Choose a reason for hiding this comment

nrc commented Feb 3, 2016

aturon commented Feb 3, 2016

petrochenkov Feb 3, 2016

Choose a reason for hiding this comment

jseyfried Feb 4, 2016

Choose a reason for hiding this comment

bors commented Feb 5, 2016

jseyfried commented Feb 6, 2016

bors commented Feb 11, 2016

bors commented Feb 11, 2016

nrc commented Feb 11, 2016

bors commented Feb 25, 2016

bors commented Feb 25, 2016

bors commented Feb 25, 2016

alexcrichton commented Feb 25, 2016