rustdoc: Don't record associated items from trait impls in the search-index #31837
Conversation
mitaa
force-pushed
the
rdoc-inherent-assoc
branch
from
cf99705 to
063b4b4
Compare
| true | ||
| } | ||
| clean::ImplItem(ref i) => { | ||
| self.parent_is_trait_impl = i.trait_.is_some(); |
There was a problem hiding this comment.
I think you can have an impl-in-an-impl, so this flag may need to be preserved and restored across the recursive calls?
mitaa
force-pushed
the
rdoc-inherent-assoc
branch
2 times, most recently
from
426d9e7 to
f240bb4
Compare
|
I pushed an update restoring the flag across recursive calls. |
| @@ -1140,6 +1145,7 @@ impl DocFolder for Cache { | |||
| } | |||
| _ => false | |||
| }; | |||
| let parent_is_trait_impl = self.parent_is_trait_impl; | |||
There was a problem hiding this comment.
Shouldn't this be saved before the match above which modifies it?
mitaa
force-pushed
the
rdoc-inherent-assoc
branch
from
f240bb4 to
f5df7e0
Compare
Yeah.. sorry, about that. |
|
⌛ Testing commit f5df7e0 with merge a46718e... |
|
💔 Test failed - auto-win-gnu-32-nopt-t |
|
@bors: retry On Wed, Feb 24, 2016 at 11:49 AM, bors notifications@github.com wrote:
|
…ichton This effectively only records associated items from either inherent impls or trait definitions in the search-index. fixes rust-lang#31808 r? @alexcrichton
This effectively only records associated items from either inherent impls or trait definitions in the search-index.
fixes #31808
r? @alexcrichton