std: Allow creating ExitStatus from raw values #33224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @aturon (rust_highfive has picked a reviewer for you, use r? to override) |
| /// Windows-specific extensions to `std::process::ExitStatus` | ||
| #[unstable(feature = "exit_status_from", issue = "32713")] | ||
| pub trait ExitStatusExt { | ||
| /// Creates a new `ExitStatus` from the raw underlying `i32` return value of |
There was a problem hiding this comment.
i32 when this function takes a u32?
Sometimes a process may be waited on externally from the standard library, in which case it can be useful to create a raw `ExitStatus` structure to return. This commit extends the existing Unix `ExitStatusExt` extension trait and adds a new Windows-specific `ExitStatusExt` extension trait to do this. The methods are currently called `ExitStatus::from_raw`. cc rust-lang#32713
alexcrichton
force-pushed
the
create-exit-status
branch
from
fab082b to
7f09b1f
Compare
|
@bors: r+ |
|
📌 Commit 7f09b1f has been approved by |
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
May 9, 2016
…aturon std: Allow creating ExitStatus from raw values Sometimes a process may be waited on externally from the standard library, in which case it can be useful to create a raw `ExitStatus` structure to return. This commit extends the existing Unix `ExitStatusExt` extension trait and adds a new Windows-specific `ExitStatusExt` extension trait to do this. The methods are currently called `ExitStatus::from_raw`. cc rust-lang#32713
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
May 9, 2016
…aturon std: Allow creating ExitStatus from raw values Sometimes a process may be waited on externally from the standard library, in which case it can be useful to create a raw `ExitStatus` structure to return. This commit extends the existing Unix `ExitStatusExt` extension trait and adds a new Windows-specific `ExitStatusExt` extension trait to do this. The methods are currently called `ExitStatus::from_raw`. cc rust-lang#32713
bors
added a commit
that referenced
this pull request
May 9, 2016
std: Allow creating ExitStatus from raw values Sometimes a process may be waited on externally from the standard library, in which case it can be useful to create a raw `ExitStatus` structure to return. This commit extends the existing Unix `ExitStatusExt` extension trait and adds a new Windows-specific `ExitStatusExt` extension trait to do this. The methods are currently called `ExitStatus::from_raw`. cc #32713
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
May 9, 2016
…aturon std: Allow creating ExitStatus from raw values Sometimes a process may be waited on externally from the standard library, in which case it can be useful to create a raw `ExitStatus` structure to return. This commit extends the existing Unix `ExitStatusExt` extension trait and adds a new Windows-specific `ExitStatusExt` extension trait to do this. The methods are currently called `ExitStatus::from_raw`. cc rust-lang#32713
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes a process may be waited on externally from the standard library, in
which case it can be useful to create a raw
ExitStatusstructure to return.This commit extends the existing Unix
ExitStatusExtextension trait and adds anew Windows-specific
ExitStatusExtextension trait to do this. The methods arecurrently called
ExitStatus::from_raw.cc #32713