Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustdoc: do not strip blanket impls in crate of origin #33514

Merged
merged 1 commit into from
May 10, 2016

Conversation

birkenfeld
Copy link
Contributor

In impl<T> Trait for T, the blanket type parameters T were recognized as "local" and "not exported", so these impls were thrown out.

Now we check if they are generic, and keep them in that case.

Fixes: #29503

In `impl<T> Trait for T`, the blanket type parameters `T` were
recognized as "local" and "not exported", so these impls were
thrown out.

Now we check if they are generic, and keep them in that case.

Fixes: rust-lang#29503
@rust-highfive
Copy link
Collaborator

r? @steveklabnik

(rust_highfive has picked a reviewer for you, use r? to override)

@alexcrichton
Copy link
Member

@bors: r+ 6100b70

Thanks!

Manishearth added a commit to Manishearth/rust that referenced this pull request May 9, 2016
rustdoc: do not strip blanket impls in crate of origin

In `impl<T> Trait for T`, the blanket type parameters `T` were recognized as "local" and "not exported", so these impls were thrown out.

Now we check if they are generic, and keep them in that case.

Fixes: rust-lang#29503
Manishearth added a commit to Manishearth/rust that referenced this pull request May 9, 2016
rustdoc: do not strip blanket impls in crate of origin

In `impl<T> Trait for T`, the blanket type parameters `T` were recognized as "local" and "not exported", so these impls were thrown out.

Now we check if they are generic, and keep them in that case.

Fixes: rust-lang#29503
bors added a commit that referenced this pull request May 9, 2016
Rollup of 10 pull requests

- Successful merges: #33129, #33224, #33370, #33383, #33431, #33474, #33480, #33496, #33509, #33514
- Failed merges:
Manishearth added a commit to Manishearth/rust that referenced this pull request May 9, 2016
rustdoc: do not strip blanket impls in crate of origin

In `impl<T> Trait for T`, the blanket type parameters `T` were recognized as "local" and "not exported", so these impls were thrown out.

Now we check if they are generic, and keep them in that case.

Fixes: rust-lang#29503
bors added a commit that referenced this pull request May 9, 2016
Rollup of 10 pull requests

- Successful merges: #33129, #33224, #33370, #33383, #33431, #33474, #33480, #33496, #33509, #33514
- Failed merges:
@bors bors merged commit 6100b70 into rust-lang:master May 10, 2016
@jethrogb
Copy link
Contributor

Was there another doc related change? Because part of #29503 seems to have already been fixed previously between nightly-2016-04-26 and nightly-2016-04-28.

@jethrogb
Copy link
Contributor

Possibly #33133

@birkenfeld birkenfeld deleted the issue-29503 branch May 10, 2016 05:10
@bluss bluss added the relnotes Marks issues that should be documented in the release notes of the next release. label May 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
relnotes Marks issues that should be documented in the release notes of the next release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants