-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
debuginfo: Fix regression in namespace handling for struct types. #33225
debuginfo: Fix regression in namespace handling for struct types. #33225
Conversation
@bors r+ |
📌 Commit 7531e15 has been approved by |
⌛ Testing commit 7531e15 with merge 850a3db... |
💔 Test failed - auto-mac-64-opt-rustbuild |
Oh, yeah, our LLDB test framework removes newlines from the output... |
7531e15
to
6074463
Compare
I changed how the test case is written. Let's give it another try. |
@bors r=eddyb |
📌 Commit 6074463 has been approved by |
💔 Test failed - auto-mac-64-opt-rustbuild |
@bors: retry On Thu, Apr 28, 2016 at 8:41 PM, bors notifications@github.com wrote:
|
💔 Test failed - auto-mac-64-opt-rustbuild |
Hm, #33171 might have introduced a race condition into the test setup... |
⌛ Testing commit 6074463 with merge 7163ed8... |
💔 Test failed - auto-mac-64-opt-rustbuild |
6074463
to
4230353
Compare
Removed the unit-struct case which seems to cause trouble for the LLDB version on the buildbots. |
@bors r=eddyb |
📌 Commit 4230353 has been approved by |
💔 Test failed - auto-mac-64-opt-rustbuild |
@bors: retry- Actually, this may not be spurious, I'll defer to you though :) |
The strange thing is, the line is right there in the output below... I'll look into it. |
…ct-ns, r=eddyb debuginfo: Fix regression in namespace handling for struct types. Fixes a small regression that has been introduced in recent refactorings. Fixes rust-lang#33193 r? @eddyb
http://buildbot.rust-lang.org/builders/auto-mac-64-opt-rustbuild/builds/957/steps/test/logs/stdio
|
⌛ Testing commit 4230353 with merge c961493... |
💔 Test failed - auto-mac-64-opt-rustbuild |
@bors r+ |
📌 Commit bb0e525 has been approved by |
⌛ Testing commit bb0e525 with merge 102bab3... |
Fixes a small regression that has been introduced in recent refactorings.
Fixes #33193
r? @eddyb