diagnostics for E0432: imports are relative to crate root #33320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @arielb1 (rust_highfive has picked a reviewer for you, use r? to override) |
| @@ -916,19 +916,21 @@ An import was unresolved. Erroneous code example: | |||
| use something::Foo; // error: unresolved import `something::Foo`. | |||
| ``` | |||
|
|
|||
| Please verify you didn't misspell the import name or the import does exist | |||
| in the module from where you tried to import it. Example: | |||
| Paths in `use` statements are relative to the crate root. To import items | |||
There was a problem hiding this comment.
Extra whitespace before "To import items".
There was a problem hiding this comment.
Sorry, old Emacs habit :)
|
Thans for your work. Please fix the nit then squash and good to get merged! |
This is curiously missing from both the short message and this long diagnostic. Refs rust-lang#31573 (not sure if it should be considered "fixed" as the short message still only refers to extern crates).
|
Thanks! r=me @steveklabnik |
|
@bors r+ |
|
📌 Commit d20b406 has been approved by |
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
May 2, 2016
diagnostics for E0432: imports are relative to crate root This is curiously missing from both the short message and this long diagnostic. Refs rust-lang#31573 (not sure if it should be considered "fixed" as the short message still only refers to extern crates).
bors
added a commit
that referenced
this pull request
May 2, 2016
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
May 3, 2016
diagnostics for E0432: imports are relative to crate root This is curiously missing from both the short message and this long diagnostic. Refs rust-lang#31573 (not sure if it should be considered "fixed" as the short message still only refers to extern crates).
bors
added a commit
that referenced
this pull request
May 3, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is curiously missing from both the short message and this long diagnostic.
Refs #31573 (not sure if it should be considered "fixed" as the short message still only refers to extern crates).