Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention initial year of publication only for the documentation copyright #33385

Merged
merged 2 commits into from
Jun 1, 2016

Conversation

cheercroaker
Copy link

I have corrected the "copyright expiration year" that was still 2015 in the documentation copyright notice.

According to #31007 it seems that we could go one step further and simplify the copyright notice to only mention the year of original publication ("Copyright © 2011" in this case).

Let me know if you would prefer this copyright notice to only mention the year of original publication (please make sure that it is really 2011 as stated in the current version of the documentation, and not 2010 like Rust's code) and I'll make the simplification.

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Manishearth (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@Manishearth
Copy link
Member

r? @steveklabnik

@steveklabnik
Copy link
Member

/cc @brson, I forget what we decided EXACTLY with this copyright stuff.

As stated in rust-lang#31007 the copyright notice should reflect the year of original publication, thus avoiding useless updates every year.
@cheercroaker
Copy link
Author

For file headers in the source code, it seems that the consensus and policy is to spend the least amount of energy on copyright dates related stuff, as reminded in this comment from @brson and recommended by @gerv .

For other copyright notices, the most recent element from Mozilla legal I have found is to reflect the year of original publication (only), as reported by @aturon .
This has been done for the COPYRIGHT and LICENCE-MIT files via #31007.

Therefore I went ahead and added another commit: no more expiration year in the copyright notice for the documentation footer, only the year of initial publication.

Please rollup, for a little less "planned obsolescence" 😉

@cheercroaker cheercroaker changed the title Bump copyright year in documentation footer Mention initial year of publication only for the documentation copyright May 24, 2016
@gerv
Copy link

gerv commented May 25, 2016

The only disadvantage of putting only initial publication years into visible copyrights in documentation is that it can lead people to erroneously assume the documentation is very old.

@brson
Copy link
Contributor

brson commented May 31, 2016

That's a good point that it'll make the docs look out of date, but I'm fine trying this to keep our policy consistent and seeing how many fresh bug reports we get about the copyright date being wrong.

@bors r+ rollup

@bors
Copy link
Contributor

bors commented May 31, 2016

📌 Commit c4ed094 has been approved by brson

@bors
Copy link
Contributor

bors commented May 31, 2016

⌛ Testing commit c4ed094 with merge d064d67...

@bors
Copy link
Contributor

bors commented May 31, 2016

💔 Test failed - auto-linux-64-cross-armhf

@alexcrichton
Copy link
Member

@bors: retry

On Tue, May 31, 2016 at 3:54 PM, bors notifications@github.com wrote:

💔 Test failed - auto-linux-64-cross-armhf
http://buildbot.rust-lang.org/builders/auto-linux-64-cross-armhf/builds/474


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#33385 (comment), or mute
the thread
https://github.com/notifications/unsubscribe/AAD95M--xXSdU3PwS90naiEN5SM1eUPWks5qHLwhgaJpZM4IWghY
.

Manishearth added a commit to Manishearth/rust that referenced this pull request Jun 1, 2016
Mention initial year of publication only for the documentation copyright

I have corrected the "copyright expiration year" that was still 2015 in the documentation copyright notice.

According to rust-lang#31007 it seems that we could go one step further and simplify the copyright notice to only mention the year of original publication ("Copyright © 2011" in this case).

Let me know if you would prefer this copyright notice to only mention the year of original publication (please make sure that it is really 2011 as stated in the current version of the documentation, and not 2010 like Rust's code) and I'll make the simplification.
bors added a commit that referenced this pull request Jun 1, 2016
Rollup of 11 pull requests

- Successful merges: #33385, #33606, #33841, #33892, #33896, #33915, #33921, #33967, #33970, #33973, #33977
- Failed merges:
@bors bors merged commit c4ed094 into rust-lang:master Jun 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants