-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: format! may or may not handle streams in future #33606
Conversation
r? @brson (rust_highfive has picked a reviewer for you, use r? to override) |
I think you removed a bit too much text as it's important info that |
If you are removing references to streams please remove the one from the first para too: "This macro is implemented in the compiler to emit calls to this module in order to format arguments at runtime into strings and streams." @maximih that first paragraph also mentions that format returns strings so maybe is sufficient. @tshepang maybe this sentence can be changed to be more clear about creating If we're removing irrelevant info, the detail that |
Isn't |
No need to talk about that here
@brson I don't understand this:
|
@tshepang The second sentence of the description of |
@bors r+ rollup |
📌 Commit 5c34892 has been approved by |
doc: format! may or may not handle streams in future No need to talk about that here
No need to talk about that here