Forbid type parameters and global paths in macro invocations #34495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This probably needs a crater run. |
|
Starting a crater run. |
|
Crater report shows 0 regressions. |
|
LGTM. cc @nrc @Manishearth |
|
LGTM too. Since this doesn't actually change the grammar, it doesn't need to be part of the breaking batch either. |
|
@eddyb r=you? |
|
@jseyfried I'd like to hear back from another compiler/lang team member, like @nrc or @nikomatsakis (but niko is on vacation right now and might not respond for a while). Or maybe we should require that, e.g. for language breaking changes, you notify @rust-lang/lang. |
|
@eddyb ok, makes sense -- no hurry. We usually land clear bug fixes that cause no measurable breakage in practice without much discussion (perhaps we shouldn't). |
|
LGTM @bors: r=eddyb |
|
📌 Commit b4611b1 has been approved by |
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Jun 29, 2016
…ons, r=eddyb Forbid type parameters and global paths in macro invocations Fixes rust-lang#28558. This is a [breaking-change]. For example, the following would break: ```rust macro_rules! m { () => { () } } fn main() { m::<T>!(); // Type parameters are no longer allowed in macro invocations ::m!(); // Global paths are no longer allowed in macro invocations } ``` Any breakage can be fixed by removing the type parameters or the leading `::` (respectively). r? @eddyb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #28558.
This is a [breaking-change]. For example, the following would break:
Any breakage can be fixed by removing the type parameters or the leading
::(respectively).r? @eddyb