Disable debuginfo tests for a given blacklist of LLDB versions #34499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
michaelwoerister
force-pushed
the
lldb-blacklist
branch
from
3f3ef4b to
cd7681a
Compare
|
A question, are you sure that it can't be fixed by building against lldb 380 headers? That's what I did for my lldb plugin. |
|
Thanks @michaelwoerister! I wonder if this logic could perhaps be moved to compiletest to ensure that this is fixed in rustbuild as well? |
|
@indutny I don't think there's a way to fix these problems the way you suggest (we are not building an LLDB plugin, just using LLDB via Python). |
|
@alexcrichton Sure, I'll look into it. |
michaelwoerister
force-pushed
the
lldb-blacklist
branch
4 times, most recently
from
37270f3 to
0e94481
Compare
michaelwoerister
force-pushed
the
lldb-blacklist
branch
from
0e94481 to
f41de0f
Compare
|
@alexcrichton I've moved the check to compiletest. The version comparison is less fine-grained there but I think that's OK. |
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Jun 29, 2016
…alexcrichton Disable debuginfo tests for a given blacklist of LLDB versions Anyone having trouble with most LLDB tests failing on OSX, please report your LLDB version here so I can add it to the blacklist. Blacklisted versions so far: * lldb-350.* cc @rust-lang/tools cc @tedhorst @indutny @jonathandturner (people from the original bug report) Fixes rust-lang#32520.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Anyone having trouble with most LLDB tests failing on OSX, please report your LLDB version here so I can add it to the blacklist.
Blacklisted versions so far:
cc @rust-lang/tools
cc @tedhorst @indutny @jonathandturner (people from the original bug report)
Fixes #32520.