Minor rewrite of std::io::empty doc example.
#34517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -78,14 +78,15 @@ pub struct Empty { _priv: () } | |||
| /// A slightly sad example of not reading anything into a buffer: | |||
| /// | |||
| /// ``` | |||
| /// use std::io; | |||
| /// use std::io::Read; | |||
| /// use std::io::{self, Read}; | |||
| /// | |||
| /// # fn foo() -> io::Result<String> { | |||
| /// let mut buffer = String::new(); | |||
| /// try!(io::empty().read_to_string(&mut buffer)); | |||
There was a problem hiding this comment.
Should all these try!s be converted to unwraps? That seems to be the modern convention?
There was a problem hiding this comment.
Works for me. I'll change them.
There was a problem hiding this comment.
Fixed in the latest force push.
frewsxcv
force-pushed
the
empty
branch
2 times, most recently
from
07de812
to
69c091e
Compare
Remove unnecessary hidden `foo` function. Demonstrate this emptiness of the resulting string. Combine imports.
frewsxcv
changed the title
std::io::Empty.std::io::empty doc example.
|
Thanks! @bors: r+ rollup |
|
📌 Commit a350ca6 has been approved by |
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Jun 28, 2016
Minor rewrite of `std::io::empty` doc example. None
bors
added a commit
that referenced
this pull request
Jun 28, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.