-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 13 pull requests #34525
Merged
Merged
Rollup of 13 pull requests #34525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Indicate how it gets created and add an example.
Remove unnecessary hidden `foo` function. Demonstrate this emptiness of the resulting string. Combine imports.
… r=steveklabnik Syntax coloring and more compact diagram Two cosmetic improvements: - New content was added a few days ago to the **Closures** chapter but it was missing rust's syntax coloring. - Also, in the **Crates and Modules** chapter, a diagram was improved to be more symmetric and to take less space.
update reference for rust-lang#29734
Traits where syntax's extra usage example more clearly r? @steveklabnik
Add example for `std::thread::sleep`. None
Use the correct types in float examples r? @steveklabnik
…teveklabnik [doc] Fix links in Ownership section of the book - Add a missing link definition for `[i32]`. - Like `[stack]` link is pointing to `...#the-stack`, append `#the-heap` to `[heap]` link.
…Gomez Add example with leading zeros I was searching for this format very long. So I added an example to the prominent section. I was thinking of putting the keyword leading in the corresponding section as well, what do you think? r? @steveklabnik
…bnik Fix E0269 error explanation r? @steveklabnik
…eGomez Expand `std::path::Component` documentation. Indicate how it gets created and add an example.
…st, r=GuillaumeGomez rustdoc: Fix inlined renamed reexports in import lists Fixes rust-lang#34473
Minor rewrite of `std::io::empty` doc example. None
Add doc example for `std::io::repeat`. None
Add doc example for `std::io::sink`. None
@bors: r+ p=10 |
📌 Commit dd56a6a has been approved by |
(rust_highfive has picked a reviewer for you, use r? to override) |
bors
added a commit
that referenced
this pull request
Jun 28, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
std::thread::sleep
. #34406, Use the correct types in float examples #34415, [doc] Fix links in Ownership section of the book #34442, Add example with leading zeros #34462, Fix E0269 error explanation #34471, Expandstd::path::Component
documentation. #34475, rustdoc: Fix inlined renamed reexports in import lists #34479, Minor rewrite ofstd::io::empty
doc example. #34517, Add doc example forstd::io::repeat
. #34518, Add doc example forstd::io::sink
. #34524