-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unused methods from MultiSpan #34965
Conversation
r? @aturon (rust_highfive has picked a reviewer for you, use r? to override) |
@bors r+ rollup |
📌 Commit f7019a4 has been approved by |
…r=sanxiyn Remove unused methods from MultiSpan Removed a couple of unused methods from MultiSpan. I thought about batching this with some other changes but wasn't sure when I'd get around to them, so PR for a tiny fix instead. This can be rollup'd.
This PR seems to have removed the only way to create a This also breaks Clippy (https://github.com/Manishearth/rust-clippy/issues/1120, https://github.com/Manishearth/rust-clippy/issues/1119) without a simple way to fix it, so I'd like to know whether I can hope getting that method back or should remove the broken Clippy feature. |
@mcarton I joined the discussion on https://github.com/Manishearth/rust-clippy/pull/1119 to see if there are alternate fixes for clippy. Since MultiSpan isn't being used in the compiler in this way, I wanted to continue to simplify it. As you point out, there's more there to be done. |
Removed a couple of unused methods from MultiSpan. I thought about batching this with some other changes but wasn't sure when I'd get around to them, so PR for a tiny fix instead.
This can be rollup'd.