-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix incorrect 'memory leak' example for Vec::set_len
.
#34989
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @brson (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
7c566ff
to
676659a
Compare
I feel like a using a |
Example was written in rust-lang#34911 Issue was brought up in this comment: rust-lang@a005b2c#commitcomment-18346958
676659a
to
1e0043e
Compare
In what ways do you think a |
I'd prefer to let @nagisa or someone else handles this PR. |
This PR is correct for all its worth. |
@nagisa: Then r+ it :p |
r=me, I guess. |
@bors: r=nagisa |
📌 Commit 1e0043e has been approved by |
…=nagisa Fix incorrect 'memory leak' example for `Vec::set_len`. Example was written in rust-lang#34911 Issue was brought up in this comment: rust-lang@a005b2c#commitcomment-18346958
Example was written in #34911
Issue was brought up in this comment:
a005b2c#commitcomment-18346958