Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect 'memory leak' example for Vec::set_len. #34989

Merged
merged 1 commit into from
Jul 24, 2016

Conversation

frewsxcv
Copy link
Member

Example was written in #34911

Issue was brought up in this comment:

a005b2c#commitcomment-18346958

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @brson (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@nagisa
Copy link
Member

nagisa commented Jul 23, 2016

I feel like a using a Box instead of Vec for elements would get the point across better.

@frewsxcv frewsxcv force-pushed the fix-set-len-doc-example branch from 676659a to 1e0043e Compare July 23, 2016 13:08
@frewsxcv
Copy link
Member Author

I feel like a using a Box instead of Vec for elements would get the point across better.

In what ways do you think a Box would be more appropriate here?

@frewsxcv
Copy link
Member Author

r? @GuillaumeGomez

@GuillaumeGomez
Copy link
Member

I'd prefer to let @nagisa or someone else handles this PR.

@nagisa
Copy link
Member

nagisa commented Jul 23, 2016

This PR is correct for all its worth.

@GuillaumeGomez
Copy link
Member

@nagisa: Then r+ it :p

@nagisa
Copy link
Member

nagisa commented Jul 23, 2016

r=me, I guess.

@GuillaumeGomez
Copy link
Member

@bors: r=nagisa

@bors
Copy link
Contributor

bors commented Jul 23, 2016

📌 Commit 1e0043e has been approved by nagisa

Manishearth added a commit to Manishearth/rust that referenced this pull request Jul 24, 2016
…=nagisa

Fix incorrect 'memory leak' example for `Vec::set_len`.

Example was written in rust-lang#34911

Issue was brought up in this comment:

rust-lang@a005b2c#commitcomment-18346958
bors added a commit that referenced this pull request Jul 24, 2016
Rollup of 7 pull requests

- Successful merges: #34965, #34972, #34975, #34976, #34977, #34988, #34989
- Failed merges:
@bors bors merged commit 1e0043e into rust-lang:master Jul 24, 2016
@frewsxcv frewsxcv deleted the fix-set-len-doc-example branch October 2, 2016 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants