std: Ignore tests where threads outlive main #34983
Conversation
|
r? @brson (rust_highfive has picked a reviewer for you, use r? to override) |
| @@ -97,7 +97,7 @@ const MAX_REFCOUNT: usize = (isize::MAX) as usize; | |||
| /// by putting it inside `Mutex` and then share `Mutex` immutably | |||
| /// with `Arc<T>` as shown below. | |||
| /// | |||
| /// ``` | |||
| /// ```no_run | |||
There was a problem hiding this comment.
Can you add a comment to prevent people from removing this?
|
r=me with fix |
Long ago we discovered that threads which outlive main and then exit while the rest of the program is exiting causes Windows to hang (rust-lang#20704). That's what was happening in this test so let's just not run this test any more.
alexcrichton
force-pushed
the
windows-flaky
branch
from
7df09db to
8487666
Compare
|
@bors: r=brson |
|
📌 Commit 8487666 has been approved by |
| @@ -21,6 +21,10 @@ | |||
| //! | |||
| //! Sharing some immutable data between threads: | |||
| //! | |||
| // Note that we **do not** run these tests here. The windows builders get super | |||
| // unhappy of a thread outlives the main thread and then exits at the same time | |||
|
⌛ Testing commit 8487666 with merge ea99866... |
|
💔 Test failed - auto-win-msvc-64-cargotest |
|
@bors: retry On Sun, Jul 24, 2016 at 11:32 PM, bors notifications@github.com wrote:
|
|
@bors: retry |
|
⌛ Testing commit 8487666 with merge 2a1a077... |
|
💔 Test failed - auto-win-msvc-64-opt |
|
@bors: retry On Tue, Jul 26, 2016 at 3:38 AM, bors notifications@github.com wrote:
|
|
@bors: p=1 (causing flaky tests on Windows) |
std: Ignore tests where threads outlive main Long ago we discovered that threads which outlive main and then exit while the rest of the program is exiting causes Windows to hang (#20704). That's what was happening in this test so let's just not run this test any more.
Long ago we discovered that threads which outlive main and then exit while the
rest of the program is exiting causes Windows to hang (#20704). That's what was
happening in this test so let's just not run this test any more.